-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cargo): aim for faster runtime on release
profile
#594
chore(cargo): aim for faster runtime on release
profile
#594
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #594 +/- ##
=====================================
Coverage 90.7% 90.7%
=====================================
Files 38 38
Lines 1086 1086
Branches 224 224
=====================================
Hits 986 986
Misses 85 85
Partials 15 15 ☔ View full report in Codecov by Sentry. |
The changes heavily increase tests duration. This is because the installation of I guess we could either:
I'm not a huge fan of the 2nd option because:
So I'll probably give a shot at the first option. In the meantime, I'll let the PR in draft, but if we decide that we're ok with the increased test duration in the meantime, I'm also ok with merging this PR as is. |
Will rebase from |
Awesome, let's see what that does to the unit test duration in the CI/CD pipeline so we can assess if we think the increased runtime peformance for end-users outweighs the increased unit test duration. |
01054f3
to
48a338d
Compare
After the rebase, it's day and night when comparing latest build with https://github.com/fpgmaas/deptry/actions/runs/8295732898. Will let you confirm that @fpgmaas but to me this looks good to merge now. |
PR Checklist
docs
is updatedDescription of changes
Per https://nnethercote.github.io/perf-book/build-configuration.html, there are a few optimisations we could apply to the artifacts we build when releasing.
Testing locally on macOS ARM, this lead to:
deptry
on a repository with ~7k files (from ~1.02s to ~970ms)The tradeoff being that we will have longer compilation times, but since this should only impact the "release" profile and not the dev one, and we do not create releases that often, I think this should be an ok tradeoff.