chore: speed up functional tests #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkniewallner
force-pushed
the
chore/speed-up-functional-tests
branch
5 times, most recently
from
008a775 to
d8d3c82
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #598 +/- ##
=======================================
- Coverage 91.1% 90.7% -0.4%
=======================================
Files 38 38
Lines 1086 1086
Branches 224 224
=======================================
- Hits 990 986 -4
- Misses 81 85 +4
Partials 15 15 ☔ View full report in Codecov by Sentry. |
mkniewallner
force-pushed
the
chore/speed-up-functional-tests
branch
2 times, most recently
from
143fe02 to
b46d7cb
Compare
mkniewallner
changed the title
deptry from wheel
mkniewallner
force-pushed
the
chore/speed-up-functional-tests
branch
2 times, most recently
from
e1a5c76 to
7a94e55
Compare
4 tasks
fpgmaas
reviewed
Mar 16, 2024
| @@ -14,13 +14,18 @@ check: ## Run code quality tools. | |||
| @echo "🚀 Checking for dependency issues: Running deptry" | |||
| @pdm run deptry python | |||
|
|
|||
| .PHONY: test | |||
There was a problem hiding this comment.
Is it an idea to keep this command to make it easier to run all unit tests locally?
Suggested change
| .PHONY: test | |
| .PHONY test: | |
| test: test-unit test-functional | |
fpgmaas
reviewed
Mar 16, 2024
| ```bash | ||
| make test |
There was a problem hiding this comment.
If we add the make test command back like suggested above, we can revert this change.
fpgmaas
reviewed
Mar 16, 2024
Makefile
Outdated
| .PHONY: test-functional | ||
| test-functional: ## Run functional tests. | ||
| @echo "🚀 Running functional tests" | ||
| @pdm run pytest tests/functional -n auto |
There was a problem hiding this comment.
Should we also add --dist loadgroup here?
Suggested change
| @pdm run pytest tests/functional -n auto | |
| @pdm run pytest tests/functional -n auto --dist loadgroup |
fpgmaas
reviewed
Mar 16, 2024
fpgmaas
reviewed
Mar 16, 2024
fpgmaas
reviewed
Mar 16, 2024
Co-authored-by: Florian Maas <fpgmaas@gmail.com>
mkniewallner
force-pushed
the
chore/speed-up-functional-tests
branch
from
716000b to
d29da65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #597.
PR Checklist
docsis updatedDescription of changes
This speeds up functional tests by implementing the 2 solutions mentioned in: #597:
deptrywheel is now built at the beginning of functional tests, then used whenever a functional test needs to bootstrap a new environmentloadgroup, to ensure that tests that use the same test project end up on the same process, since if we have multiple tests that bootstrap the same project, we only bootstrap the project onceThe speedup is definitetely noticeable by comparing a recent build with a build in this PR. If we take
linux (3.12, x86_64)as an example, we go from ~167s to ~66s.