add support for dynamic dependencies with setuptools #724
Conversation
|
Will add tests and things later. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #724 +/- ##
=======================================
- Coverage 92.8% 92.3% -0.5%
=======================================
Files 35 35
Lines 920 946 +26
Branches 165 168 +3
=======================================
+ Hits 854 874 +20
- Misses 52 57 +5
- Partials 14 15 +1 ☔ View full report in Codecov by Sentry. |
|
Hey! Thanks for your contribution. I will check it out soon, I first need to sort out the bug in the CI/CD pipeline :) |
|
Could you please add a functional test? i.e.
|
|
Looks like there were a few formatting issues; https://github.com/fpgmaas/deptry/actions/runs/9409803890/job/25970899533?pr=724. You can resolve this by installing the pre-commit hooks locally with |
I think in this case, it would be best to catch the |
| ) | ||
|
|
||
| raise DependencySpecificationNotFoundError(self.requirements_files) | ||
|
|
||
| def _project_uses_setuptools(self, pyproject_toml: dict[str, Any]) -> bool: |
There was a problem hiding this comment.
| def _project_uses_setuptools(self, pyproject_toml: dict[str, Any]) -> bool: | |
| @staticmethod | |
| def _project_uses_setuptools(pyproject_toml: dict[str, Any]) -> bool: |
| ) | ||
| return False | ||
|
|
||
| def _project_uses_dynamic_dependencies(self, pyproject_toml: dict[str, Any]) -> bool: |
There was a problem hiding this comment.
| def _project_uses_dynamic_dependencies(self, pyproject_toml: dict[str, Any]) -> bool: | |
| @staticmethod | |
| def _project_uses_dynamic_dependencies(pyproject_toml: dict[str, Any]) -> bool: |
| ) | ||
| return False | ||
|
|
||
| def _project_dynamic_requirements_file(self, pyproject_toml: dict[str, Any]) -> tuple[str, ...]: |
There was a problem hiding this comment.
| def _project_dynamic_requirements_file(self, pyproject_toml: dict[str, Any]) -> tuple[str, ...]: | |
| @staticmethod | |
| def _project_dynamic_requirements_file(pyproject_toml: dict[str, Any]) -> tuple[str, ...]: |
| ) | ||
|
|
||
| raise DependencySpecificationNotFoundError(self.requirements_files) | ||
|
|
||
| def _project_uses_setuptools(self, pyproject_toml: dict[str, Any]) -> bool: |
There was a problem hiding this comment.
Could you move the 3 new methods between _project_uses_pdm and _project_uses_pep_621? That way we use the same order as the order methods are called from build method.
| ) | ||
| return False | ||
|
|
||
| def _project_dynamic_requirements_file(self, pyproject_toml: dict[str, Any]) -> tuple[str, ...]: |
There was a problem hiding this comment.
Maybe we can remove this method and make _project_uses_dynamic_dependencies return a tuple[bool, tuple[str, ...]], like
| 3. a `[tool.setuptools.dynamic]` section containing `dependencies = { file = [some_requirements_file] }`, | ||
|
|
||
| then _deptry_ will assume the project uses setuptools with dynamic dependencies. It will extract dependencies | ||
| from the file specified in the `[tool.setuptools.dynamic]` section. |
There was a problem hiding this comment.
| from the file specified in the `[tool.setuptools.dynamic]` section. | |
| from the files specified in the `[tool.setuptools.dynamic]` section. |
since this could be a list of files?
PR Checklist
docsis updatedDescription of changes
This pull request adds support for dependencies dynamically specified when using setuptools. This fixes #421. The changes should not affect users of setuptools that do not use dynamic dependencies, as in this case it will revert to the PEP621 compliant dependency checker.
Known issue: if the specified file to source dependencies from does not exist, this code will crash. @fpgmaas what is the best way to present this error to the user?