-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support setuptools
dynamic dependencies
#894
Merged
mkniewallner
merged 10 commits into
main
from
feat/support-setuptools-dynamic-dependencies
Oct 21, 2024
Merged
feat: support setuptools
dynamic dependencies
#894
mkniewallner
merged 10 commits into
main
from
feat/support-setuptools-dynamic-dependencies
Oct 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkniewallner
commented
Oct 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #894 +/- ##
=======================================
+ Coverage 92.4% 92.5% +0.1%
=======================================
Files 37 37
Lines 994 1011 +17
Branches 96 99 +3
=======================================
+ Hits 919 936 +17
Misses 60 60
Partials 15 15 ☔ View full report in Codecov by Sentry. |
4 tasks
fpgmaas
approved these changes
Oct 21, 2024
3ffbce5
to
1ff9347
Compare
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #421.
Closes #724.
PR Checklist
docs
is updatedDescription of changes
Continuing the work made in #724.
Specification for
setuptools
dynamic dependecnies: https://setuptools.pypa.io/en/stable/userguide/pyproject_config.html#dynamic-metadata.In comparison to the initial implementation, this PR moves the logic into
PEP621DependencyGetter
, since dynamic dependencies insetuptools
are only supported when using PEP 621 metadata definition. This also makes it possible to handle cases where only dependencies or optional dependencies are defined dynamically, since it's a valid use case.