Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building G6K & FPyLLL currently fails #278

Closed
ludopulles opened this issue Nov 25, 2024 · 5 comments · Fixed by #288
Closed

Building G6K & FPyLLL currently fails #278

ludopulles opened this issue Nov 25, 2024 · 5 comments · Fixed by #288

Comments

@ludopulles
Copy link
Contributor

The newest cysignals package causes an error during ./bootstrap.sh resulting in a long list of error messages:

In file included from build/src/fpylll/fplll/lll.cpp:1359:
/pathtorepository/g6k/g6k-env/lib64/python3.12/site-packages/cysignals/macros.h: In function 'int _sig_on_prejmp(const char*, const char*, int)':
/pathtorepository/g6k/g6k-env/lib64/python3.12/site-packages/cysignals/macros.h:117:5: error: 'cysigs' was not declared in this scope
  117 |     cysigs.s = message;
      |     ^~~~~~
/pathtorepository/g6k/g6k-env/lib64/python3.12/site-packages/cysignals/macros.h:117:5: note: the macro 'cysigs' had not yet been defined
build/src/fpylll/fplll/lll.cpp:2815: note: it was later defined here
 2815 | #define cysigs (*__pyx_vp_9cysignals_7signals_cysigs)
      |
...

It's known: sagemath/cysignals#212

Temporary workaround: downgrade to cysignals version 1.11.4:

source ./activate
pip install --force-reinstall -v "cysignals==1.11.4"
@malb
Copy link
Collaborator

malb commented Nov 25, 2024

Yup, looks like we need to adapt FPyLLL to the current cysignals, I'll try to find some time to do this soon, but certainly not before the weekend. (Partial) PRs welcome :)

@ludopulles
Copy link
Contributor Author

I'd say: wait for the issue in cysignals to be fixed and shipped :).

@AntonKueltz
Copy link
Contributor

FYI poetry based builds are still broken because they use pyproject.toml to decide the cysignals version. I've proposed a change in the above PR and verified this locally. Happy to take any further steps needed to test and validate.

malb added a commit that referenced this issue Dec 4, 2024
…d-builds

Issue #278: Reference functional cysignals version
ludopulles added a commit to ludopulles/fpylll that referenced this issue Dec 20, 2024
- pip install directly,
- only append once all code to fpylll-env/bin/activate so deactivating is not necessary
- pick up on return code of `make clean` in FPLLL, like G6K does.
- fix DeprecationWarning in setup.py and docs/conf.py for getting `__version__`
- depend on most recent cysignals (1.12.2) again as this one works again.

Closes: fplll#278
ludopulles added a commit to ludopulles/fpylll that referenced this issue Dec 20, 2024
- pip install directly,
- only append once all code to fpylll-env/bin/activate so deactivating is not necessary
- pick up on return code of `make clean` in FPLLL, like G6K does.
- fix DeprecationWarning in setup.py and docs/conf.py for getting `__version__`
- depend on most recent cysignals (1.12.2) again as this one works again.

Closes: fplll#278
ludopulles added a commit to ludopulles/fpylll that referenced this issue Dec 20, 2024
- pip install directly,
- only append once all code to fpylll-env/bin/activate so deactivating is not necessary
- pick up on return code of `make clean` in FPLLL, like G6K does.
- fix DeprecationWarning in setup.py and docs/conf.py for getting `__version__`
- depend on most recent cysignals (1.12.2) again as this one works again.

Closes: fplll#278
@malb malb closed this as completed in #288 Dec 21, 2024
@malb malb closed this as completed in d0d2aa4 Dec 21, 2024
@dimpase
Copy link

dimpase commented Jan 6, 2025

Could we have a new minor release, as the now obsolete constraint on cysignals version blocks updating of a lot of stuff in sage?

@malb
Copy link
Collaborator

malb commented Jan 7, 2025

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants