Update bootstrap.sh & setup.py #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- only append once all code to fpylll-env/bin/activate so deactivating is not necessary - pick up on return code of `make clean` in FPLLL, like G6K does. - fix DeprecationWarning in setup.py and docs/conf.py for getting `__version__` - depend on most recent cysignals (1.12.2) again as this one works again. - change return values of bootstrap.sh to make all errors have different ones Closes: fplll#278
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make cleanin FPLLL, like G6K does.__version__Note: $retval was not updated after
make installpreviously.Closes: #278