Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack 5 warnings #31

Closed
matteobad opened this issue May 19, 2020 · 9 comments
Closed

Webpack 5 warnings #31

matteobad opened this issue May 19, 2020 · 9 comments

Comments

@matteobad
Copy link
Contributor

Hi @fqborges, thank you for the great work. I was wondering if you plan to update this plugin to support Webpack 5. I'm trying to integrate it into some work project and there are some deprecation warnings.

To be more specific:

(node:12688) [DEP_WEBPACK_CHUNK_HAS_ENTRY_MODULE] DeprecationWarning: Chunk.hasEntryModule: Use new ChunkGraph API
(node:12688) [DEP_WEBPACK_CHUNK_ENTRY_MODULE] DeprecationWarning: Chunk.entryModule: Use new ChunkGraph API
(node:12688) [DEP_WEBPACK_MODULE_INDEX] DeprecationWarning: Module.index: Use new ModuleGraph API
(node:12688) [DEP_WEBPACK_DEPRECATION_ARRAY_TO_SET] DeprecationWarning: chunk.files was changed from Array to Set (using Array method 'filter' is deprecated)

I can help with the upgrade if needed. Let me know and thank you in advance.

@fqborges
Copy link
Owner

As far as I know, webpack 5 does not generate the empty js for css entries.

see: webpack-contrib/mini-css-extract-plugin#85 (comment)
There is also PR I can't find right now.

@matteobad
Copy link
Contributor Author

This is very interesting. I tried today with the latest beta.16 and I still have the empty JS without this plugin... so I guess we will have to wait until the official release

@LeSuisse
Copy link

Hi,

From what I gather from here webpack/webpack#11088 (comment) it looks like this plugin will still be useful with Webpack 5 😞

@fqborges
Copy link
Owner

@LeSuisse Thanks for the info.

@webdiscus
Copy link

webdiscus commented Oct 20, 2020

Hi @matteobad, @fqborges I have fixed Webpack 5 deprecation messages (like DEP_WEBPACK_...) and fixed some integration tests. Now all Integration tests pass with Webpack 5.1.3.

See my PR: #41
For usage with Webpack 5 you can try my fork: https://github.com/webdiscus/webpack-remove-empty-scripts

@kuworking
Copy link

When using the plugin I see Module.entryModule: Multiple entry modules are not supported by the deprecated API (Use the new ChunkGroup API)

"webpack": "5.4.0",
"webpack-fix-style-only-entries": "^0.6.0",

As suggested, If using https://github.com/webdiscus/webpack-remove-empty-scripts there's no error and the plugin works

@ankurk91
Copy link

#43

@bigskillet
Copy link

Confirming that Webpack 5 is still creating the extra js file and also confirming the deprecation warning.

@fqborges
Copy link
Owner

fqborges commented Feb 4, 2021

The current package version is not compatible with webpack 5. There is a fork here that is compatible: https://github.com/webdiscus/webpack-remove-empty-scripts

@fqborges fqborges closed this as completed Feb 4, 2021
mobinzk added a commit to EtchUK/Etch.OrchardCore.ThemeBoilerplate that referenced this issue Feb 18, 2021
…scripts` as it was not compatible with Webpack 5.

fqborges/webpack-fix-style-only-entries#31

Updated fractal to latest version.
Updated webpack to version 5.
Updated depricated packages.
peterkeating pushed a commit to EtchUK/Etch.OrchardCore.ThemeBoilerplate that referenced this issue Feb 21, 2021
…scripts` as it was not compatible with Webpack 5.

fqborges/webpack-fix-style-only-entries#31

Updated fractal to latest version.
Updated webpack to version 5.
Updated depricated packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants