-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack 5 warnings #31
Comments
As far as I know, webpack 5 does not generate the empty js for css entries. see: webpack-contrib/mini-css-extract-plugin#85 (comment) |
This is very interesting. I tried today with the latest beta.16 and I still have the empty JS without this plugin... so I guess we will have to wait until the official release |
Hi, From what I gather from here webpack/webpack#11088 (comment) it looks like this plugin will still be useful with Webpack 5 😞 |
@LeSuisse Thanks for the info. |
Hi @matteobad, @fqborges I have fixed Webpack 5 deprecation messages (like DEP_WEBPACK_...) and fixed some integration tests. Now all Integration tests pass with Webpack 5.1.3. See my PR: #41 |
When using the plugin I see
As suggested, If using https://github.com/webdiscus/webpack-remove-empty-scripts there's no error and the plugin works |
Confirming that Webpack 5 is still creating the extra js file and also confirming the deprecation warning. |
The current package version is not compatible with webpack 5. There is a fork here that is compatible: https://github.com/webdiscus/webpack-remove-empty-scripts |
…scripts` as it was not compatible with Webpack 5. fqborges/webpack-fix-style-only-entries#31 Updated fractal to latest version. Updated webpack to version 5. Updated depricated packages.
…scripts` as it was not compatible with Webpack 5. fqborges/webpack-fix-style-only-entries#31 Updated fractal to latest version. Updated webpack to version 5. Updated depricated packages.
Hi @fqborges, thank you for the great work. I was wondering if you plan to update this plugin to support Webpack 5. I'm trying to integrate it into some work project and there are some deprecation warnings.
To be more specific:
(node:12688) [DEP_WEBPACK_CHUNK_HAS_ENTRY_MODULE] DeprecationWarning: Chunk.hasEntryModule: Use new ChunkGraph API (node:12688) [DEP_WEBPACK_CHUNK_ENTRY_MODULE] DeprecationWarning: Chunk.entryModule: Use new ChunkGraph API (node:12688) [DEP_WEBPACK_MODULE_INDEX] DeprecationWarning: Module.index: Use new ModuleGraph API (node:12688) [DEP_WEBPACK_DEPRECATION_ARRAY_TO_SET] DeprecationWarning: chunk.files was changed from Array to Set (using Array method 'filter' is deprecated)
I can help with the upgrade if needed. Let me know and thank you in advance.
The text was updated successfully, but these errors were encountered: