New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] fix deprecation messages and integration tests for Webpack5 #41

Closed

webdiscus wants to merge 1 commit into fqborges:master from webdiscus:master

webdiscus commented Oct 21, 2020

In Webpack 5 fixed deprecation messages:
- DEP_WEBPACK_CHUNK_HAS_ENTRY_MODULE
- DEP_WEBPACK_CHUNK_ENTRY_MODULE
- DEP_WEBPACK_DEPRECATION_ARRAY_TO_SET
- DEP_WEBPACK_MODULE_INDEX
Update packages for Webpack 5.
Fix integration test script for using with Webpack 5.
Fix a BUG of terser-webpack-plugin (generate the futile file vendor.js.LICENSE.txt) in the production test vendor+multi-js-entry-css-entry.
Fix module structure in README.md.


          [BUGFIX] fix deprecation messages and fix integration tests for Webpa…

ef50644

…ck 5

webdiscus mentioned this pull request

Webpack 5 warnings #31

Closed

Owner

fqborges commented Oct 21, 2020

Thanks for your work, but I cannot accept this PR as it is.

Issues I spotted:

Lots of changes on formatting only.
It seems to just drop webpack 4 support.
All webpack 4 tests are replaced by webpack 5 tests. As we have to support both, we need both tests.

fqborges closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet