Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require pydantic<=2.8.2 #836

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Require pydantic<=2.8.2 #836

merged 3 commits into from
Sep 10, 2024

Conversation

tcompa
Copy link
Collaborator

@tcompa tcompa commented Sep 9, 2024

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md

@tcompa tcompa linked an issue Sep 9, 2024 that may be closed by this pull request
Pin pydantic to <=2.8.2 #834
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

@tcompa
Copy link
Collaborator Author

tcompa commented Sep 9, 2024

As expected, the external-package-manifest-creation test fails before 6540c48 and passes afterwards.

jluethi
jluethi approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@jluethi jluethi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I can also confirm from the user package that pinning pydantic to <=2.8.2 works. PR approved :)

@tcompa tcompa merged commit 6e431a3 into main Sep 10, 2024
19 checks passed
@tcompa tcompa deleted the 834-pin-pydantic-to-=282 branch September 10, 2024 06:36
@tcompa tcompa mentioned this pull request Sep 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jluethi jluethi jluethi approved these changes

@lorenzocerrone lorenzocerrone Awaiting requested review from lorenzocerrone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pin pydantic to <=2.8.2
2 participants
@tcompa @jluethi