fix: Use default Cost Center of the Company for additional discount #37234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Discount Accounting in enabled in Selling Settings, use Company default Cost Center while making GL entries for additional_discount_account
vr-greycube
requested review from
deepeshgarg007 and
rohitwaghchaure
as code owners
github-actions
bot
added
accounts
needs-tests
deepeshgarg007
added a commit
that referenced
this pull request
Sep 27, 2023
…-37234 fix: Use default Cost Center of the Company for additional discount (backport #37234)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Oct 4, 2023
# [14.42.0](v14.41.2...v14.42.0) (2023-10-04) ### Bug Fixes * add only float row values for total ([020aedb](020aedb)) * currency symbol in the Supplier Quotation Comparison report ([#37337](#37337)) ([82e8606](82e8606)) * Description field for the 'Ignore Available Stock' ([#37293](#37293)) ([7f1483a](7f1483a)) * do not consider submitted Work Orders in the Production Plan Res… ([#37343](#37343)) ([c3aeb2d](c3aeb2d)) * ignore user permissions for `Source Warehouse` (backport [#37313](#37313)) ([#37314](#37314)) ([04f0dfb](04f0dfb)) * incorrect qty for material request in Production Plan ([#37270](#37270)) ([8fe4a4d](8fe4a4d)) * Not unique table/alias: 'tabTask' (backport [#37285](#37285)) ([#37298](#37298)) ([95e0bf5](95e0bf5)) * party format in test ([28756bf](28756bf)) * PCV posting issues ([#37029](#37029)) ([92eabe3](92eabe3)) * process soa filter for multiselect ([4962b67](4962b67)) * query for multiselect filter ([6d7aa2a](6d7aa2a)) * set route filter values for AP ([49f0f1c](49f0f1c)) * set route filter values for AR ([2b30727](2b30727)) * summary report filters ([403ff69](403ff69)) * trial balance report freezes when adding filters (backport [#37264](#37264)) ([#37265](#37265)) ([6a8146b](6a8146b)) * Use default Cost Center of the Company for additional discount ([#37234](#37234)) ([e483b4a](e483b4a)) * validation message for valuation rate ([#37301](#37301)) ([643bb05](643bb05)) ### Features * asset salvage_value_percentage (backport [#37302](#37302)) ([#37334](#37334)) ([6daea6c](6daea6c))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When Discount Accounting in enabled in Selling Settings, in Sales Invoice the company Default Cot Center is not picked up for the GL entry for the discount amount.
Solution:
use the Company Default Cost Center while making GL entries for additional discount
Closes #37233