Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Not unique table/alias: 'tabTask' #37285

Merged
merged 1 commit into from
Sep 29, 2023
Merged

fix: Not unique table/alias: 'tabTask' #37285

merged 1 commit into from
Sep 29, 2023

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Sep 28, 2023

@s-aga-r s-aga-r added the backport version-14-hotfix backport to version 14 label Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #37285 (a619e56) into develop (2c7d6ae) will decrease coverage by 0.01%.
Report is 26 commits behind head on develop.
The diff coverage is 84.87%.

@@             Coverage Diff             @@
##           develop   #37285      +/-   ##
===========================================
- Coverage    66.70%   66.70%   -0.01%     
===========================================
  Files          794      794              
  Lines        62541    62541              
===========================================
- Hits         41721    41720       -1     
- Misses       20820    20821       +1
Files Coverage Δ
...ounts/doctype/purchase_invoice/purchase_invoice.py 83.95% <100.00%> (ø)
...post_accounting_ledger/repost_accounting_ledger.py 100.00% <100.00%> (ø)
...xt/accounts/doctype/sales_invoice/sales_invoice.py 83.95% <100.00%> (ø)
...rpnext/assets/doctype/asset_repair/asset_repair.py 67.22% <ø> (ø)
erpnext/controllers/subcontracting_controller.py 88.82% <ø> (ø)
...cturing/doctype/production_plan/production_plan.py 84.02% <100.00%> (ø)
...ext/manufacturing/doctype/work_order/work_order.py 80.32% <100.00%> (ø)
erpnext/stock/stock_ledger.py 84.31% <100.00%> (ø)
...e/period_closing_voucher/period_closing_voucher.py 84.10% <73.33%> (ø)
erpnext/controllers/accounts_controller.py 84.85% <75.00%> (ø)

... and 1 file with indirect coverage changes

@s-aga-r s-aga-r marked this pull request as ready for review September 29, 2023 09:34
@s-aga-r s-aga-r merged commit 361e555 into frappe:develop Sep 29, 2023
mergify bot pushed a commit that referenced this pull request Sep 29, 2023
@s-aga-r @mergify
fix: Not unique table/alias: 'tabTask' (#37285)
ac68b32 
(cherry picked from commit 361e555)
@mergify mergify bot mentioned this pull request Sep 29, 2023
Merged
s-aga-r added a commit that referenced this pull request Sep 29, 2023
@mergify @s-aga-r
fix: Not unique table/alias: 'tabTask' (backport #37285) (#37298)
95e0bf5 
fix: Not unique table/alias: 'tabTask' (#37285)

(cherry picked from commit 361e555)

Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Oct 4, 2023
@frappe-bot
chore(release): Bumped to Version 14.42.0
9f1b932 
# [14.42.0](v14.41.2...v14.42.0) (2023-10-04)

### Bug Fixes

* add only float row values for total ([020aedb](020aedb))
* currency symbol in the Supplier Quotation Comparison report ([#37337](#37337)) ([82e8606](82e8606))
* Description field for the 'Ignore Available Stock' ([#37293](#37293)) ([7f1483a](7f1483a))
* do not consider submitted Work Orders in the Production Plan Res… ([#37343](#37343)) ([c3aeb2d](c3aeb2d))
* ignore user permissions for `Source Warehouse` (backport [#37313](#37313)) ([#37314](#37314)) ([04f0dfb](04f0dfb))
* incorrect qty for material request in Production Plan ([#37270](#37270)) ([8fe4a4d](8fe4a4d))
* Not unique table/alias: 'tabTask' (backport [#37285](#37285)) ([#37298](#37298)) ([95e0bf5](95e0bf5))
* party format in test ([28756bf](28756bf))
* PCV posting issues ([#37029](#37029)) ([92eabe3](92eabe3))
* process soa filter for multiselect ([4962b67](4962b67))
* query for multiselect filter ([6d7aa2a](6d7aa2a))
* set route filter values for AP ([49f0f1c](49f0f1c))
* set route filter values for AR ([2b30727](2b30727))
* summary report filters ([403ff69](403ff69))
* trial balance report freezes when adding filters (backport [#37264](#37264)) ([#37265](#37265)) ([6a8146b](6a8146b))
* Use default Cost Center of the Company for additional discount ([#37234](#37234)) ([e483b4a](e483b4a))
* validation message for valuation rate ([#37301](#37301)) ([643bb05](643bb05))

### Features

* asset salvage_value_percentage (backport [#37302](#37302)) ([#37334](#37334)) ([6daea6c](6daea6c))
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@s-aga-r