Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ignore ERR journals in Statment of Accounts #38820

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

ruthra-kumar
Copy link
Member

Statement of Accounts for General Ledger will have a checkbox to ignore Exchange Rate Revaluation and Exchange Gain Or Loss journals from the statement
Screenshot 2023-12-18 at 1 40 28 PM

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #38820 (39ef75e) into develop (f7b2380) will increase coverage by 0.10%.
Report is 55 commits behind head on develop.
The diff coverage is 50.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #38820      +/-   ##
===========================================
+ Coverage    60.08%   60.18%   +0.10%     
===========================================
  Files          759      759              
  Lines        69556    69767     +211     
===========================================
+ Hits         41790    41992     +202     
- Misses       27766    27775       +9     
Files Coverage Δ
erpnext/accounts/utils.py 73.82% <ø> (+0.03%) ⬆️
...t/accounts/report/general_ledger/general_ledger.py 69.64% <50.00%> (-0.03%) ⬇️
...ement_of_accounts/process_statement_of_accounts.py 54.91% <50.00%> (-0.13%) ⬇️

... and 24 files with indirect coverage changes

@ruthra-kumar ruthra-kumar merged commit b5f3013 into frappe:develop Dec 18, 2023
14 checks passed
ruthra-kumar added a commit that referenced this pull request Dec 18, 2023
…-38820

refactor: ignore ERR journals in Statment of Accounts (backport #38820)
ruthra-kumar added a commit that referenced this pull request Dec 18, 2023
…-38820

refactor: ignore ERR journals in Statment of Accounts (backport #38820)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2024
@ruthra-kumar ruthra-kumar removed the needs-tests This PR needs automated unit-tests. label Feb 1, 2024
@ruthra-kumar
Copy link
Member Author

test case added in General Ledger on #39671

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant