Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move ignore ERR filter from SOA to General Ledger #39671

Conversation

ruthra-kumar
Copy link
Member

Adding Ignore Exchange Rate Revaluation Journals to General Ledger
continues: #38820

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Feb 1, 2024
@ruthra-kumar ruthra-kumar added backport version-14-hotfix backport to version 14 backport version-15-hotfix and removed needs-tests This PR needs automated unit-tests. labels Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (079cd30) 60.19% compared to head (beff566) 60.13%.
Report is 33 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #39671      +/-   ##
===========================================
- Coverage    60.19%   60.13%   -0.07%     
===========================================
  Files          757      758       +1     
  Lines        70799    70953     +154     
===========================================
+ Hits         42620    42665      +45     
- Misses       28179    28288     +109     
Files Coverage Δ
...t/accounts/report/general_ledger/general_ledger.py 70.49% <100.00%> (+0.68%) ⬆️
erpnext/controllers/status_updater.py 88.42% <ø> (ø)
erpnext/controllers/subcontracting_controller.py 89.43% <100.00%> (+0.05%) ⬆️
erpnext/manufacturing/doctype/bom/bom.py 73.35% <100.00%> (+0.03%) ⬆️
...ement_of_accounts/process_statement_of_accounts.py 54.77% <50.00%> (-0.15%) ⬇️

... and 12 files with indirect coverage changes

@ruthra-kumar ruthra-kumar changed the title refactor: move ignore ERR filters from SOA to General Ledger refactor: move ignore ERR filter from SOA to General Ledger Feb 1, 2024
@ruthra-kumar ruthra-kumar merged commit 518b06c into frappe:develop Feb 1, 2024
19 checks passed
ruthra-kumar added a commit that referenced this pull request Feb 1, 2024
…-39671

refactor: move ignore ERR filter from SOA to General Ledger (backport #39671)
ruthra-kumar added a commit that referenced this pull request Feb 1, 2024
…-39671

refactor: move ignore ERR filter from SOA to General Ledger (backport #39671)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant