Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: undefined error in Budget Variance and Profitability report #39067

Merged
merged 2 commits into from
Jan 1, 2024
Merged

fix: undefined error in Budget Variance and Profitability report #39067

merged 2 commits into from
Jan 1, 2024

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Jan 1, 2024 •
edited
Loading

Removing dimensions filter setup in Budget Variance Report and Profitability Analysis reports.

  1. Profitability Analysis already has dynamic dimension filter selection.
  2. Branch Variance report filters are refactored to dynamically load dimensions in the drop down select.

Internal Reference: 7814

@ruthra-kumar
fix: undefined error in Budget Variance and Profitability report
92bc962 
'Budget' and 'Budget Account' doesn't have support for dynamic
dimension. It only supports hard-coded ones -  Project and Cost Center
@ruthra-kumar ruthra-kumar merged commit d048644 into frappe:develop Jan 1, 2024
6 checks passed
This was referenced Jan 1, 2024
Merged
Merged
ruthra-kumar added a commit that referenced this pull request Jan 1, 2024
@ruthra-kumar
Merge pull request #39072 from frappe/mergify/bp/version-15-hotfix/pr…
f3088e0 
…-39067

fix: undefined error in Budget Variance and Profitability report (backport #39067)
ruthra-kumar added a commit that referenced this pull request Jan 1, 2024
@ruthra-kumar
Merge pull request #39071 from frappe/mergify/bp/version-14-hotfix/pr…
78771cd 
…-39067

fix: undefined error in Budget Variance and Profitability report (backport #39067)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ruthra-kumar