Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undefined error in Budget Variance and Profitability report (backport #39067) #39071

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 1, 2024

This is an automatic backport of pull request #39067 done by Mergify.
Cherry-pick of 92bc962 has failed:

On branch mergify/bp/version-14-hotfix/pr-39067
Your branch is up to date with 'origin/version-14-hotfix'.

You are currently cherry-picking commit 92bc962f60.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   erpnext/accounts/report/budget_variance_report/budget_variance_report.js

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   erpnext/accounts/report/profitability_analysis/profitability_analysis.js

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

'Budget' and 'Budget Account' doesn't have support for dynamic
dimension. It only supports hard-coded ones -  Project and Cost Center

(cherry picked from commit 92bc962)

# Conflicts:
#	erpnext/accounts/report/profitability_analysis/profitability_analysis.js
@ruthra-kumar ruthra-kumar force-pushed the mergify/bp/version-14-hotfix/pr-39067 branch from 0f14137 to bfc94cf Compare January 1, 2024 12:12
@ruthra-kumar ruthra-kumar merged commit 78771cd into version-14-hotfix Jan 1, 2024
5 checks passed
@ruthra-kumar ruthra-kumar deleted the mergify/bp/version-14-hotfix/pr-39067 branch January 1, 2024 12:19
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.58.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants