Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RM valuation rate in SCR #39541

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Jan 24, 2024

Source / Ref: 8066

Steps to replicate:

  • Create Subcontracted PO.
  • Create PO -> SCO.
  • Transfer RM (Batch) to Supplier Warehouse.
  • Create SCO -> SCR. The Valuation Rate didn't get set for the Batch RM Items.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jan 24, 2024
@s-aga-r s-aga-r marked this pull request as ready for review January 25, 2024 13:38
@s-aga-r s-aga-r merged commit 9fd1692 into frappe:version-14-hotfix Jan 25, 2024
11 checks passed
frappe-pr-bot pushed a commit that referenced this pull request Jan 30, 2024
## [14.61.3](v14.61.2...v14.61.3) (2024-01-30)

### Bug Fixes

* Asset Depreciation WDV as per Income Tax Act ([b840eb9](b840eb9))
* asset module test cases ([f604798](f604798))
* **Batch:** reload doc after splitting ([c759406](c759406))
* default enable closing stock balance (backport [#39551](#39551)) ([#39553](#39553)) ([1e32c62](1e32c62))
* do not auto-populate item delivery date ([1e341f0](1e341f0))
* do not consider rejected warehouses in pick list ([#39539](#39539)) ([f6725e4](f6725e4))
* do not delete batches implicitly ([9a5995a](9a5995a))
* **ecom:** do not create a new contact if a contact already exists ([#39290](#39290)) ([47c591c](47c591c))
* email list for auto reorder material request ([780c069](780c069))
* enqueue JV submission when more than 100 accounts ([66be3c5](66be3c5))
* fetch correct quantity and amount for grouped asset ([1dacb79](1dacb79))
* incorrect amount in the material request item (backport [#39567](#39567)) ([#39568](#39568)) ([c26f7bb](c26f7bb))
* linter issue ([941f882](941f882))
* not able to edit / change address from portal ([e3fdb6f](e3fdb6f))
* not able to edit address through portal ([b310a55](b310a55))
* Payment Terms Status for Sales Order report should show all payment terms from order not only this comming from template ([2953959](2953959))
* perf issue while submitting stock entry (backport [#39634](#39634)) ([#39641](#39641)) ([3ee0555](3ee0555))
* prevent extra transfer against inter transfer transaction (backport [#39213](#39213)) ([#39595](#39595)) ([bf61030](bf61030))
* qtn tests using delivery date ([c50988b](c50988b))
* return doc obj after submit ([0472879](0472879))
* RM valuation rate in SCR ([#39541](#39541)) ([9fd1692](9fd1692))
* typo's and parameter changes ([41c074d](41c074d))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.61.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants