Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct field name in accounts controller #39884

Merged
merged 1 commit into from
Feb 14, 2024
Merged

fix: use correct field name in accounts controller #39884

merged 1 commit into from
Feb 14, 2024

Conversation

rohitg-pbspl
Copy link
Contributor

Bug

  • Not able to fetch Advance Payments in Sales Invoice and Purchase Invoice
  • Field name in Query is wrong

Screenshot from 2024-02-13 18-18-25

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Feb 13, 2024
@rohitg-pbspl rohitg-pbspl mentioned this pull request Feb 13, 2024
Closed
@barredterra barredterra added the squash Meant to tell reviewers that this PR should be squashed into a single commit while merging. label Feb 13, 2024
@barredterra barredterra changed the title #bugFix - Not fetching advances done with Jv's in [SI, PI] fix: use correct field name in accounts controller Feb 13, 2024
@s-aga-r s-aga-r merged commit b124081 into frappe:develop Feb 14, 2024
14 of 15 checks passed
mergify bot pushed a commit that referenced this pull request Feb 14, 2024
@rohitg-pbspl @mergify
fix: use correct field name in accounts controller (#39884)
bbfe15b 
Changes to get advance payments in SI or PI from JV's

(cherry picked from commit b124081)

# Conflicts:
#	erpnext/controllers/accounts_controller.py
mergify bot pushed a commit that referenced this pull request Feb 14, 2024
@rohitg-pbspl @mergify
fix: use correct field name in accounts controller (#39884)
d543daf 
Changes to get advance payments in SI or PI from JV's

(cherry picked from commit b124081)
This was referenced Feb 14, 2024
Closed
Merged
s-aga-r pushed a commit that referenced this pull request Feb 14, 2024
@mergify @rohitg-pbspl
fix: use correct field name in accounts controller (backport #39884) (#…
f08b424 
…39897)

fix: use correct field name in accounts controller (#39884)

Changes to get advance payments in SI or PI from JV's

(cherry picked from commit b124081)

Co-authored-by: Rohit Gunjegaonkar <135806454+rohitg-pbspl@users.noreply.github.com>
frappe-pr-bot pushed a commit that referenced this pull request Feb 14, 2024
@frappe-bot
chore(release): Bumped to Version 15.14.0
c78d085 
# [15.14.0](v15.13.0...v15.14.0) (2024-02-14)

### Bug Fixes

*  production plan issue with sales order (backport [#39901](#39901)) ([#39904](#39904)) ([88a7248](88a7248))
* add permissions to SRE (backport [#39780](#39780)) ([#39786](#39786)) ([ba05648](ba05648))
* Brazilian COA for demo data creation ([#39839](#39839)) ([4daee6d](4daee6d))
* calculate `stock_value_diff` ([5a66c85](5a66c85))
* create SBB for `transfer_qty` in SE (backport [#39835](#39835)) ([#39863](#39863)) ([92e6017](92e6017))
* do not consider rejected warehouses in pick list (backport [#39539](#39539)) (backport [#39804](#39804)) ([#39811](#39811)) ([30dacce](30dacce))
* incorrect planned qty in PP (backport [#39785](#39785)) ([#39793](#39793)) ([60e04ab](60e04ab))
* landed cost voucher not submitting because of incorrect reference (backport [#39898](#39898)) ([#39900](#39900)) ([a548f12](a548f12))
* remove duplicates from tax category map ([3c6114a](3c6114a))
* set rate for PO created against BO (backport [#39765](#39765)) ([#39767](#39767)) ([2213886](2213886))
* stock entry for use serial batch fields (backport [#39843](#39843)) ([#39844](#39844)) ([43fce29](43fce29))
* use correct field name in accounts controller (backport [#39884](#39884)) ([#39897](#39897)) ([f08b424](f08b424))
* **ux:** set rate as price list rate on uom change in MR (backport [#39816](#39816)) ([#39818](#39818)) ([63b4d20](63b4d20))
* validate duplicate SBB (backport [#39862](#39862)) ([#39866](#39866)) ([a2f1a96](a2f1a96))
* warehouse issue in pick list (backport [#39826](#39826)) ([#39827](#39827)) ([b625b05](b625b05))

### Features

* get RM costs from consumption entry in manufacture SE (backport [#39822](#39822)) ([#39847](#39847)) ([2d5f186](2d5f186))

### Performance Improvements

* cached get_last_purchase_details to fix performance issue (backport [#39854](#39854)) ([#39856](#39856)) ([c643e70](c643e70))
* production plan submission (backport [#39846](#39846)) ([#39860](#39860)) ([10f17df](10f17df))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
accounts backport version-14-hotfix backport to version 14 backport version-15-hotfix needs-tests This PR needs automated unit-tests. squash Meant to tell reviewers that this PR should be squashed into a single commit while merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohitg-pbspl @barredterra @s-aga-r