Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: landed cost voucher not submitting because of incorrect reference #39898

Merged
merged 1 commit into from
Feb 14, 2024
Merged

fix: landed cost voucher not submitting because of incorrect reference #39898

merged 1 commit into from
Feb 14, 2024

Conversation

rohitwaghchaure
Copy link
Collaborator

  1. Make two purchase receipts
  2. Make two landed cost voucher and change the reference of purchase_receipt_item for the first landed cost voucher (use second purchase receipt's line item reference)
  3. Submit the second landed cost voucher first
  4. Then submit the first landed cost voucher
  5. System will throw the error "Debit and credit not equal"

Solution
System should not allow to put the incorrect purchase receipt item in the landed cost voucher

@github-actions github-actions bot added buying needs-tests This PR needs automated unit-tests. labels Feb 14, 2024
@rohitwaghchaure rohitwaghchaure force-pushed the fixed-landed-cost-voucher branch from 6691322 to a6a600a Compare February 14, 2024 09:43
@rohitwaghchaure rohitwaghchaure merged commit 6239fd7 into frappe:develop Feb 14, 2024
12 of 13 checks passed
mergify bot pushed a commit that referenced this pull request Feb 14, 2024
@rohitwaghchaure @mergify
fix: landed cost voucher not submitting because of incorrect reference (
8622969 
#39898)

(cherry picked from commit 6239fd7)
mergify bot pushed a commit that referenced this pull request Feb 14, 2024
@rohitwaghchaure @mergify
fix: landed cost voucher not submitting because of incorrect reference (
1c7110a 
#39898)

(cherry picked from commit 6239fd7)
This was referenced Feb 14, 2024
Merged
Merged
rohitwaghchaure added a commit that referenced this pull request Feb 14, 2024
@mergify @rohitwaghchaure
fix: landed cost voucher not submitting because of incorrect referenc…
a548f12 
…e (backport #39898) (#39900)

fix: landed cost voucher not submitting because of incorrect reference (#39898)

(cherry picked from commit 6239fd7)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
rohitwaghchaure added a commit that referenced this pull request Feb 14, 2024
@mergify @rohitwaghchaure
fix: landed cost voucher not submitting because of incorrect referenc…
d0b9c56 
…e (backport #39898) (#39899)

fix: landed cost voucher not submitting because of incorrect reference (#39898)

(cherry picked from commit 6239fd7)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Feb 14, 2024
@frappe-bot
chore(release): Bumped to Version 15.14.0
c78d085 
# [15.14.0](v15.13.0...v15.14.0) (2024-02-14)

### Bug Fixes

*  production plan issue with sales order (backport [#39901](#39901)) ([#39904](#39904)) ([88a7248](88a7248))
* add permissions to SRE (backport [#39780](#39780)) ([#39786](#39786)) ([ba05648](ba05648))
* Brazilian COA for demo data creation ([#39839](#39839)) ([4daee6d](4daee6d))
* calculate `stock_value_diff` ([5a66c85](5a66c85))
* create SBB for `transfer_qty` in SE (backport [#39835](#39835)) ([#39863](#39863)) ([92e6017](92e6017))
* do not consider rejected warehouses in pick list (backport [#39539](#39539)) (backport [#39804](#39804)) ([#39811](#39811)) ([30dacce](30dacce))
* incorrect planned qty in PP (backport [#39785](#39785)) ([#39793](#39793)) ([60e04ab](60e04ab))
* landed cost voucher not submitting because of incorrect reference (backport [#39898](#39898)) ([#39900](#39900)) ([a548f12](a548f12))
* remove duplicates from tax category map ([3c6114a](3c6114a))
* set rate for PO created against BO (backport [#39765](#39765)) ([#39767](#39767)) ([2213886](2213886))
* stock entry for use serial batch fields (backport [#39843](#39843)) ([#39844](#39844)) ([43fce29](43fce29))
* use correct field name in accounts controller (backport [#39884](#39884)) ([#39897](#39897)) ([f08b424](f08b424))
* **ux:** set rate as price list rate on uom change in MR (backport [#39816](#39816)) ([#39818](#39818)) ([63b4d20](63b4d20))
* validate duplicate SBB (backport [#39862](#39862)) ([#39866](#39866)) ([a2f1a96](a2f1a96))
* warehouse issue in pick list (backport [#39826](#39826)) ([#39827](#39827)) ([b625b05](b625b05))

### Features

* get RM costs from consumption entry in manufacture SE (backport [#39822](#39822)) ([#39847](#39847)) ([2d5f186](2d5f186))

### Performance Improvements

* cached get_last_purchase_details to fix performance issue (backport [#39854](#39854)) ([#39856](#39856)) ([c643e70](c643e70))
* production plan submission (backport [#39846](#39846)) ([#39860](#39860)) ([10f17df](10f17df))
frappe-pr-bot pushed a commit that referenced this pull request Feb 14, 2024
@frappe-bot
chore(release): Bumped to Version 14.62.4
22ace5c 
## [14.62.4](v14.62.3...v14.62.4) (2024-02-14)

### Bug Fixes

*  production plan issue with sales order (backport [#39901](#39901)) ([#39903](#39903)) ([ab7e323](ab7e323))
* accommodate for default rounding method in v14 ([d6a758d](d6a758d))
* broken route option in Profitability report ([f79e0d1](f79e0d1))
* calculate `stock_value_diff` ([8f58b61](8f58b61))
* cancel asset capitalization ([2438600](2438600))
* do not throw validation for canceled SLE (backport [#39769](#39769)) ([#39810](#39810)) ([2885b8f](2885b8f))
* Handling circular linking while cancelling asset capitalization ([f2d094d](f2d094d))
* incorrect planned qty in PP (backport [#39785](#39785)) ([#39792](#39792)) ([df9d52d](df9d52d))
* landed cost voucher not submitting because of incorrect reference (backport [#39898](#39898)) ([#39899](#39899)) ([d0b9c56](d0b9c56))
* remove duplicates from tax category map ([c56f3a5](c56f3a5))
* set rate for PO created against BO (backport [#39765](#39765)) ([#39766](#39766)) ([de47e67](de47e67))
* set route options to cost center ([#37235](#37235)) ([79a16ba](79a16ba))
* **ux:** set rate as price list rate on uom change in MR (backport [#39816](#39816)) ([#39817](#39817)) ([de6e8c7](de6e8c7))

### Performance Improvements

* cached get_last_purchase_details to fix performance issue (backport [#39854](#39854)) ([#39855](#39855)) ([08e0271](08e0271))
* production plan submission (backport [#39846](#39846)) ([#39859](#39859)) ([a61cffd](a61cffd))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007

@s-aga-r s-aga-r Awaiting requested review from s-aga-r

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix buying needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rohitwaghchaure