fix: AttributeError in Bank Statement Import (backport #40494) #40499
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is a combination of 2 different bugs.
Bank Statement Import
Scenario on which error occur
This 'AttributeError' only shows up if there were any errors during import, which now it does due to [1] above.
Now, when you retry the import, you'll get the AttributeError due to the uninitialized 'payload_count'.
Cause
'Bank Statement Import' inherits 'Data Import', which has 'payload_count' attribute.
But, It looks like 'Bank Statment Import' is not properly initializing 'Data Import' fields[2]. Since, the Importer class heavly relies on the object being of class 'Data Import', any missing attributes of that class causes hard to debug issues like this.
This is an automatic backport of pull request #40494 done by [Mergify](https://mergify.com).