Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update item_tax_rate in backend (backport #44884) #45007

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 31, 2024

Issue: item_tax_rate is only set from the front end.
If the Item tax template is updated from the backend incorrect taxes are calculated.

Steps on how to replicate this issue

  • Create one item with only one item tax template
  • Create a transaction for this item. This should auto-fetch item tax template.
  • Unset item tax template from the item. Save

With unset, it doesn't unset item tax rate, causing incorrect final taxes.

Closes: #41081
Frappe Support Issue: https://support.frappe.io/app/hd-ticket/27836

backport-version-15-hotfix
backport-varsion-14-hotfix


This is an automatic backport of pull request #44884 done by [Mergify](https://mergify.com).

(cherry picked from commit de54c0b)

# Conflicts:
#	erpnext/controllers/taxes_and_totals.py
Copy link
Contributor Author

mergify bot commented Dec 31, 2024

Cherry-pick of de54c0b has failed:

On branch mergify/bp/version-14-hotfix/pr-44884
Your branch is up to date with 'origin/version-14-hotfix'.

You are currently cherry-picking commit de54c0b41f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   erpnext/controllers/taxes_and_totals.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@ruthra-kumar ruthra-kumar force-pushed the mergify/bp/version-14-hotfix/pr-44884 branch from e8fe974 to 36bd535 Compare December 31, 2024 11:25
@ruthra-kumar ruthra-kumar force-pushed the mergify/bp/version-14-hotfix/pr-44884 branch from 36bd535 to fd2a1a0 Compare December 31, 2024 11:40
@ruthra-kumar
Copy link
Member

ruthra-kumar commented Jan 1, 2025

Tax Detail report was removed in develop and v15 through #34192 and is unmaintained in v14. Removing test files of Tax Detail report to unblock this change.

Will hold for sometime before completely removing this report.

@ruthra-kumar

This comment was marked as outdated.

@ruthra-kumar ruthra-kumar force-pushed the mergify/bp/version-14-hotfix/pr-44884 branch from 593ef3b to 02a0bf3 Compare January 1, 2025 07:38
@ruthra-kumar ruthra-kumar merged commit 97612eb into version-14-hotfix Jan 1, 2025
10 checks passed
@ruthra-kumar ruthra-kumar deleted the mergify/bp/version-14-hotfix/pr-44884 branch January 1, 2025 08:18
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.78.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants