Set lines for "Allowed Roles" in pv-inverter to active #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Peter, my apologies for not seeing your pull request earlier. I'll review and merge asap if all looks OK. |
is it possible ti have it merged? |
freakent
pushed a commit
that referenced
this pull request
Nov 10, 2023
|
The changes proposed in this PR have already been reflected in the new beta release. Generally I am not comfortable merging changes that I have no tests for. However since you have verified the changes proposed in the PR I have rolled this into the main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
as written in #23 the PR activates the "allowed roles" lines for the pv-inverter to change it's position between AC-IN and AC-OUT:
This is necessary for easier integration of Hoymiles inverters to push there values with the dbus-mqqt-devices driver automatically from Open-DTU to VRM portal. See also PR tbnobody/OpenDTU#377
Thanks,
Peter