-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Victron Cerbo / VRM portal #377
Conversation
added some source to publish Hoymiles values via MqTT to Victron Venus OS mosquitto server, subscribe at Victron OS mosquitto server to get portal ID and deviceInstance. Add support for Victron Cerbo / VRM portal Some new functions and variables for publishing values via MqTT to Victron Venus OS mosquitto server. code cleaning victron part in webapp Current phase input publisch phase bugfix current phase bugfix hh lll df ll dsgdsg xvccxv sfsfd sdfsdf dgfsdf hh ff dgdfg d dsfdsf asf Update code from master Runden und Schleifenänderung round#1 round#2 round#3 round#4 Searching for value 0 in Voltage Finding some errors Fieldname and value corrected sfdsdf adfdsf Try to save some memory Loopänderung um Registrierung nicht alle 5 sekunden auszuführen. Changed inverter registration procedure, similar to Hass Fehler in Variablenvereinbarung behoben. Maxpower & Errorcode in loop eingefügt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just did a first rough review.
Some general remarks: It would be nice if the victron code would be as much as possible in the dedicated victron class. Is there really a need to move it into the MqttPublishing class?
VSCode also provides an auto code formatter. Just press F1 and choose "Format Document" (or "Dokument formatieren"). This would lead to a unique code style.
Another general hint... you should not merge my future commits into your branch. This would lead to the following commit order (sample):
This is very bad if I want to merge this later on.
This can be achieved by rebasing your changes on top of mine. This is described here: https://ardupilot.org/dev/docs/git-rebase.html This can also be done in the VSCode UI. Your current branch should be your feature branch and you should rebase onto the upstream master: The downside of this technique is, that you are rewriting your git history because you are changing the order of your commits compared to the upstream master. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Hello,
to get information about the Hoymiles inverters in the Victron VRM Portal i add some code like the MqTT Homeassistant implementation for the Victron Cerbo. Enabling the MqTT part for Victron in the MqTT settings:
And putting the inverter to the right current phase (L1,L2 or L3):
The OpenDTU is sending the serial to Victron Cerbo and the devices will be registered as MqTT device via the https://github.com/freakent/dbus-mqtt-devices installed on Victron Cerbo:
After the registration the OpenDTU is publishing via MqTT the values of the Hoymiles inverters to the Victron Cerbo:
And in the Victron VRM portal you will see an inverter:
It is possible to set the position of the inverters on AC-IN or AC-OUT, when the services.yml is adopted like: freakent/dbus-mqtt-devices#23
And when setting the current phase in the inverter menu to "None" or "L0", the inverter will be disabled in the Victron Portal:
and can be removed from the device list with: