Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper sets _host->version to the plugin version not the host version #287

Closed
baconpaul opened this issue Aug 14, 2024 · 4 comments
Closed
Labels
solved in next solved in branch "next"

Comments

@baconpaul
Copy link
Collaborator

In short circuit I construct my clap about screen this way (in my local branch - merging soon)

engine->runningEnvironment =
        "Clap-First " + std::string(h->name) + " " + std::string(h->version);

where h is my clap_host_t * passed in at construction. Fine.

The CLAP in bitwig shows this

Screenshot 2024-08-14 at 9 47 09 AM

The VST3 wrapped in bitwig though shows this

Screenshot 2024-08-14 at 9 47 25 AM

(0.7.225.0 is my plugin version number)

and the AUv2 wrapped in logic shows the same

Screenshot 2024-08-14 at 9 48 00 AM

(once I merge #286 to remove the specious -wrapper string)

so I think we need to go and use the protocols to find the running host version and report it if possible. Or at least report the clap wrapper version rather than the plugin version.

@baconpaul
Copy link
Collaborator Author

Note that the AUv2 adds (6029) which is the logic application bundle to the host name before the (CLAP-as-AUv2)

And we probably want some build option to make those terser perhaps?

@defiantnerd
Copy link
Collaborator

Those strings are actually only in debug builds.

@baconpaul
Copy link
Collaborator Author

Are you sure? I think you are confusing the plugin name with the clap _host->name

_hostname.append(" (CLAP-as-AUv2-wrapper)");

that's not debug guarded

wrapper_hostname.append(" (CLAP-as-VST3)");

and neither is that. And I just did a release build and the screen for the VST3 was unchanged

@baconpaul
Copy link
Collaborator Author

I think the right solution here is probably a clap wrapper host information extension. Let me ponder that a bit.

baconpaul added a commit to baconpaul/clap-wrapper that referenced this issue Oct 12, 2024
This commit does a few things

1. Makes the wrapper host author and URL the free audio locations
2. Sets the wrapper host versio properly to the WRAPPER version not
   to the PLUGIN version, when used as a subordinate cmake, by using
   PROJECT_VERSION rather than CMAKE_PROJECT_VERSION to set the ifdef
3. Reads the human readable string out of the bundle for auv2 version
   which makes the host read as "Logic Pro 11.0.1 (Clap-as-AUV2)"
   rather than "Logic Pro (6029) (Clap-as-AUv2)".
4. Ups the cmake version to 0.11.0 in anticipation of the move of
   next to main

Addresses free-audio#287
baconpaul added a commit that referenced this issue Oct 12, 2024
This commit does a few things

1. Makes the wrapper host author and URL the free audio locations
2. Sets the wrapper host versio properly to the WRAPPER version not
   to the PLUGIN version, when used as a subordinate cmake, by using
   PROJECT_VERSION rather than CMAKE_PROJECT_VERSION to set the ifdef
3. Reads the human readable string out of the bundle for auv2 version
   which makes the host read as "Logic Pro 11.0.1 (Clap-as-AUV2)"
   rather than "Logic Pro (6029) (Clap-as-AUv2)".
4. Ups the cmake version to 0.11.0 in anticipation of the move of
   next to main

Addresses #287
@baconpaul baconpaul added the solved in next solved in branch "next" label Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved in next solved in branch "next"
Projects
None yet
Development

No branches or pull requests

2 participants