Update the wrapper host display to be more accurate #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit does a few things 1. Makes the wrapper host author and URL the free audio locations 2. Sets the wrapper host versio properly to the WRAPPER version not to the PLUGIN version, when used as a subordinate cmake, by using PROJECT_VERSION rather than CMAKE_PROJECT_VERSION to set the ifdef 3. Reads the human readable string out of the bundle for auv2 version which makes the host read as "Logic Pro 11.0.1 (Clap-as-AUV2)" rather than "Logic Pro (6029) (Clap-as-AUv2)". 4. Ups the cmake version to 0.11.0 in anticipation of the move of next to main Addresses free-audio#287
13 tasks
defiantnerd
reviewed
Oct 12, 2024
| @@ -173,8 +173,8 @@ Plugin::Plugin(IHost* host) | |||
| : _host{CLAP_VERSION, | |||
| this, | |||
| host->host_get_name(), | |||
| "defiant nerd", | |||
There was a problem hiding this comment.
Yeah I thought about a list but decided to just teamify it. Hope that’s ok!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit does a few things
Addresses #287