Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

Updated scripts are blocking tests on main repo #204

Open
4 tasks
raisedadead opened this issue Aug 1, 2018 · 0 comments
Open
4 tasks

Updated scripts are blocking tests on main repo #204

raisedadead opened this issue Aug 1, 2018 · 0 comments
Assignees
@raisedadead
Labels
type: bug Applied to potential show stopper issues. These need priority attention.

Comments

@raisedadead
Copy link
Member

raisedadead commented Aug 1, 2018 •
edited
Loading

At the minute we aren't able to use the curriculum from v3.1.2 onwards. This is because of a breaking change that has broken the tests on the main repo.

We need to evaluate the changes introduced in #127 and consolidate the schema for the changes both curriculum and main repo side.

Todo:

  • Is releasedOn necessary? This is one of the keys breaking tests.
  • Make it obvious that any change to schema is a MAJOR change.
  • The schema should probably be only on the curriculum side as a single source of truth.
  • ...

/cc @Bouncey @scissorsneedfoodtoo can we get on a call to discuss further?
@raisedadead raisedadead added the type: bug Applied to potential show stopper issues. These need priority attention. label Aug 1, 2018
@raisedadead raisedadead self-assigned this Aug 1, 2018
@raisedadead raisedadead mentioned this issue Sep 18, 2018
Merged
7 tasks
scissorsneedfoodtoo added a commit to scissorsneedfoodtoo/freeCodeCamp that referenced this issue Sep 19, 2018
@scissorsneedfoodtoo
fix(seed): Change schema so tests pass
d1ae6fc 
This is just a quick fix for the issue with the schema differences
between curriculum and the main fCC repo brought up in
freeCodeCamp/curriculum#204. The changes to
the schema here bring it in line with the more recently changed schema
in curriculum, and `npm run test` pass with the curriculum NPM package
3.1.2.
scissorsneedfoodtoo added a commit to scissorsneedfoodtoo/curriculum that referenced this issue Sep 20, 2018
@scissorsneedfoodtoo
fix(schema): change schema and unpack script to fix tests in main repo
c2f1365 
Added an additional argument to the getChallenges function call in unpack.js to act as a flag for
when the unpack script is running. Then modified the lodash omit array so that translations are
included in the array when the test suite is running, but excluded from the array when the unpack
script is running. Effectively this means that the translations are not included in the challenge
block when going through the test suite, but included in the challenge block for the unpack script.
Finally I removed the unnecessary releasedOn section in unpackedChallenge.js, and removed both
releasedOn and translations from challengeSchema.js.

All of these changes should fix the tests
over on the main fCC branch.

ISSUES CLOSED: Partially addresses freeCodeCamp#204
@scissorsneedfoodtoo scissorsneedfoodtoo mentioned this issue Sep 20, 2018
Merged
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@raisedadead raisedadead

Labels
type: bug Applied to potential show stopper issues. These need priority attention.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@raisedadead