This repository has been archived by the owner on Sep 25, 2019. It is now read-only.
fix(schema): change schema and unpack script to fix tests in main repo #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an additional argument to the getChallenges function call in unpack.js to act as a flag for when the unpack script is running. Then modified the lodash omit array so that translations are included in the array when the test suite is running, but excluded from the array when the unpack script is running. Effectively this means that the translations are not included in the challenge block when going through the test suite, but included in the challenge block for the unpack script. Finally I removed the unnecessary releasedOn section in unpackedChallenge.js, and removed both releasedOn and translations from challengeSchema.js. All of these changes should fix the tests over on the main fCC branch. ISSUES CLOSED: Partially addresses freeCodeCamp#204
raisedadead
approved these changes
Sep 20, 2018
|
Just to confirm this will not need any changes over at the fCC main? |
|
No, nothing should need to be changed in main. I installed the latest npm package in the main staging branch, then modified the getChallenges.js file of the package like I did here, and ran the test suite. The tests seemed to pass fine! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added an additional argument to the getChallenges function call in unpack.js to act as a flag for
when the unpack script is running. Then modified the lodash omit array so that translations are
included in the array when the test suite is running, but excluded from the array when the unpack
script is running. Effectively this means that the translations are not included in the challenge
block when going through the test suite, but included in the challenge block for the unpack script.
Finally I removed the unnecessary releasedOn section in unpackedChallenge.js, and removed both
releasedOn and translations from challengeSchema.js.
All of these changes should fix the tests over on the main fCC branch.
Pre-Submission Checklist
devbranch.fix/,feature/, ortranslate/(e.g.fix/challenge-tests)npm test.npm run committo generate a conventional commit message.Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
If they were done on the web interface you have ensured that you are creating conventional commit messages.
Checklist:
Partially addresses #204