Skip to content

Commit

Permalink
p9fs: remove duplicated code
Browse files Browse the repository at this point in the history
This code is using the vnode after it has been released and causing a
panic when a p9fs shared volume is unmounted. In fact, it seems like it's
just duplicated code left behind from a bad merge.

PR:		279887
Reported by:	Michael Dexter

Reviewed by: imp
Pull Request: #1323
  • Loading branch information
daniloegea authored and bsdimp committed Jul 13, 2024
1 parent c55f56d commit a6ca6df
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions sys/fs/p9fs/p9fs_vnops.c
Original file line number Diff line number Diff line change
Expand Up @@ -125,16 +125,6 @@ p9fs_cleanup(struct p9fs_node *np)
/* Destroy the vm object and flush associated pages. */
vnode_destroy_vobject(vp);

/* Remove the vnode from hash list if vnode is not already deleted */
if ((np->flags & P9FS_NODE_DELETED) == 0)
vfs_hash_remove(vp);

/* Invalidate all entries to a particular vnode. */
cache_purge(vp);

/* Destroy the vm object and flush associated pages. */
vnode_destroy_vobject(vp);

/* Remove all the FID */
p9fs_fid_remove_all(np, FALSE);

Check warning on line 130 in sys/fs/p9fs/p9fs_vnops.c

View workflow job for this annotation

GitHub Actions / Style Checker

Missing Signed-off-by: line

Check warning on line 130 in sys/fs/p9fs/p9fs_vnops.c

View workflow job for this annotation

GitHub Actions / Style Checker

Missing Signed-off-by: line
Expand Down

0 comments on commit a6ca6df

Please sign in to comment.