p9fs: remove duplicated code #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markpeek
approved these changes
Jul 9, 2024
|
this looks good to me. I'll land it after I use it to test running a CI cycle over multiple PRs. |
bsdimp
pushed a commit
to concussious/freebsd-src
that referenced
this pull request
Jul 13, 2024
This code is using the vnode after it has been released and causing a panic when a p9fs shared volume is unmounted. In fact, it seems like it's just duplicated code left behind from a bad merge. PR: 279887 Reported by: Michael Dexter Reviewed by: imp Pull Request: freebsd#1323
bsdimp
force-pushed
the
p9fs_panic_umount
branch
2 times, most recently
from
3cfc78f to
a6ca6df
Compare
+ service routing restart breaks on dhcp + change my copyright from inbox to home Fixes: 75eda00 MFC after: 3 days Reported by: Graham Perrin, zlei Reviewed by: imp Pull Request: freebsd#1316
This code is using the vnode after it has been released and causing a panic when a p9fs shared volume is unmounted. In fact, it seems like it's just duplicated code left behind from a bad merge. PR: 279887 Reported by: Michael Dexter Reviewed by: imp Pull Request: freebsd#1323
markjdb
pushed a commit
to markjdb/cheribsd
that referenced
this pull request
Jul 31, 2024
This code is using the vnode after it has been released and causing a panic when a p9fs shared volume is unmounted. In fact, it seems like it's just duplicated code left behind from a bad merge. PR: 279887 Reported by: Michael Dexter Reviewed by: imp Pull Request: freebsd/freebsd-src#1323 (cherry picked from commit a6ca6df)
markjdb
pushed a commit
to markjdb/cheribsd
that referenced
this pull request
Jul 31, 2024
This code is using the vnode after it has been released and causing a panic when a p9fs shared volume is unmounted. In fact, it seems like it's just duplicated code left behind from a bad merge. PR: 279887 Reported by: Michael Dexter Reviewed by: imp Pull Request: freebsd/freebsd-src#1323 (cherry picked from commit a6ca6df)
markjdb
pushed a commit
to markjdb/cheribsd
that referenced
this pull request
Aug 6, 2024
This code is using the vnode after it has been released and causing a panic when a p9fs shared volume is unmounted. In fact, it seems like it's just duplicated code left behind from a bad merge. PR: 279887 Reported by: Michael Dexter Reviewed by: imp Pull Request: freebsd/freebsd-src#1323 (cherry picked from commit a6ca6df)
markjdb
pushed a commit
to markjdb/cheribsd
that referenced
this pull request
Aug 10, 2024
This code is using the vnode after it has been released and causing a panic when a p9fs shared volume is unmounted. In fact, it seems like it's just duplicated code left behind from a bad merge. PR: 279887 Reported by: Michael Dexter Reviewed by: imp Pull Request: freebsd/freebsd-src#1323 (cherry picked from commit a6ca6df)
markjdb
pushed a commit
to markjdb/cheribsd
that referenced
this pull request
Aug 13, 2024
This code is using the vnode after it has been released and causing a panic when a p9fs shared volume is unmounted. In fact, it seems like it's just duplicated code left behind from a bad merge. PR: 279887 Reported by: Michael Dexter Reviewed by: imp Pull Request: freebsd/freebsd-src#1323 (cherry picked from commit a6ca6df)
markjdb
pushed a commit
to markjdb/cheribsd
that referenced
this pull request
Aug 15, 2024
This code is using the vnode after it has been released and causing a panic when a p9fs shared volume is unmounted. In fact, it seems like it's just duplicated code left behind from a bad merge. PR: 279887 Reported by: Michael Dexter Reviewed by: imp Pull Request: freebsd/freebsd-src#1323 (cherry picked from commit a6ca6df)
markjdb
pushed a commit
to markjdb/cheribsd
that referenced
this pull request
Aug 21, 2024
This code is using the vnode after it has been released and causing a panic when a p9fs shared volume is unmounted. In fact, it seems like it's just duplicated code left behind from a bad merge. PR: 279887 Reported by: Michael Dexter Reviewed by: imp Pull Request: freebsd/freebsd-src#1323 (cherry picked from commit a6ca6df)
markjdb
pushed a commit
to markjdb/cheribsd
that referenced
this pull request
Aug 26, 2024
This code is using the vnode after it has been released and causing a panic when a p9fs shared volume is unmounted. In fact, it seems like it's just duplicated code left behind from a bad merge. PR: 279887 Reported by: Michael Dexter Reviewed by: imp Pull Request: freebsd/freebsd-src#1323 (cherry picked from commit a6ca6df)
markjdb
pushed a commit
to markjdb/cheribsd
that referenced
this pull request
Aug 28, 2024
This code is using the vnode after it has been released and causing a panic when a p9fs shared volume is unmounted. In fact, it seems like it's just duplicated code left behind from a bad merge. PR: 279887 Reported by: Michael Dexter Reviewed by: imp Pull Request: freebsd/freebsd-src#1323 (cherry picked from commit a6ca6df)
markjdb
pushed a commit
to markjdb/cheribsd
that referenced
this pull request
Aug 28, 2024
This code is using the vnode after it has been released and causing a panic when a p9fs shared volume is unmounted. In fact, it seems like it's just duplicated code left behind from a bad merge. PR: 279887 Reported by: Michael Dexter Reviewed by: imp Pull Request: freebsd/freebsd-src#1323 (cherry picked from commit a6ca6df)
markjdb
pushed a commit
to markjdb/cheribsd
that referenced
this pull request
Aug 28, 2024
This code is using the vnode after it has been released and causing a panic when a p9fs shared volume is unmounted. In fact, it seems like it's just duplicated code left behind from a bad merge. PR: 279887 Reported by: Michael Dexter Reviewed by: imp Pull Request: freebsd/freebsd-src#1323 (cherry picked from commit a6ca6df)
markjdb
pushed a commit
to markjdb/cheribsd
that referenced
this pull request
Sep 4, 2024
This code is using the vnode after it has been released and causing a panic when a p9fs shared volume is unmounted. In fact, it seems like it's just duplicated code left behind from a bad merge. PR: 279887 Reported by: Michael Dexter Reviewed by: imp Pull Request: freebsd/freebsd-src#1323 (cherry picked from commit a6ca6df)
markjdb
pushed a commit
to markjdb/cheribsd
that referenced
this pull request
Sep 10, 2024
This code is using the vnode after it has been released and causing a panic when a p9fs shared volume is unmounted. In fact, it seems like it's just duplicated code left behind from a bad merge. PR: 279887 Reported by: Michael Dexter Reviewed by: imp Pull Request: freebsd/freebsd-src#1323 (cherry picked from commit a6ca6df)
markjdb
pushed a commit
to markjdb/cheribsd
that referenced
this pull request
Sep 12, 2024
This code is using the vnode after it has been released and causing a panic when a p9fs shared volume is unmounted. In fact, it seems like it's just duplicated code left behind from a bad merge. PR: 279887 Reported by: Michael Dexter Reviewed by: imp Pull Request: freebsd/freebsd-src#1323 (cherry picked from commit a6ca6df)
markjdb
pushed a commit
to markjdb/cheribsd
that referenced
this pull request
Sep 15, 2024
This code is using the vnode after it has been released and causing a panic when a p9fs shared volume is unmounted. In fact, it seems like it's just duplicated code left behind from a bad merge. PR: 279887 Reported by: Michael Dexter Reviewed by: imp Pull Request: freebsd/freebsd-src#1323 (cherry picked from commit a6ca6df)
markjdb
pushed a commit
to markjdb/cheribsd
that referenced
this pull request
Oct 16, 2024
This code is using the vnode after it has been released and causing a panic when a p9fs shared volume is unmounted. In fact, it seems like it's just duplicated code left behind from a bad merge. PR: 279887 Reported by: Michael Dexter Reviewed by: imp Pull Request: freebsd/freebsd-src#1323 (cherry picked from commit a6ca6df)
markjdb
pushed a commit
to markjdb/cheribsd
that referenced
this pull request
Oct 16, 2024
This code is using the vnode after it has been released and causing a panic when a p9fs shared volume is unmounted. In fact, it seems like it's just duplicated code left behind from a bad merge. PR: 279887 Reported by: Michael Dexter Reviewed by: imp Pull Request: freebsd/freebsd-src#1323 (cherry picked from commit a6ca6df)
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Oct 30, 2024
This code is using the vnode after it has been released and causing a panic when a p9fs shared volume is unmounted. In fact, it seems like it's just duplicated code left behind from a bad merge. PR: 279887 Reported by: Michael Dexter Reviewed by: imp Pull Request: freebsd/freebsd-src#1323
markjdb
pushed a commit
to markjdb/cheribsd
that referenced
this pull request
Oct 30, 2024
This code is using the vnode after it has been released and causing a panic when a p9fs shared volume is unmounted. In fact, it seems like it's just duplicated code left behind from a bad merge. PR: 279887 Reported by: Michael Dexter Reviewed by: imp Pull Request: freebsd/freebsd-src#1323 (cherry picked from commit a6ca6df)
fichtner
pushed a commit
to opnsense/src
that referenced
this pull request
Jan 12, 2025
This code is using the vnode after it has been released and causing a panic when a p9fs shared volume is unmounted. In fact, it seems like it's just duplicated code left behind from a bad merge. PR: 279887 Reported by: Michael Dexter Reviewed by: imp Pull Request: freebsd/freebsd-src#1323
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is using the vnode after it has been released and causing a panic when a p9fs shared volume is unmounted. In fact, it seems like it's just duplicated code left behind from a bad merge.
PR: 279887
Reported by: Michael Dexter
See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279887 for more details.
It seems to me that this code originated from here https://github.com/Juniper/virtfs/blob/jnpr/virtfs/sys/dev/virtio/9pfs/virtfs_vnops.c#L97
With this patch I can mount/umount p9fs shares reliably.
Feedback from someone familiar with the code would be appreciated.