networking.7: erase confusing caveat #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @grahamperrin |
|
I guess it's OK, thanks. |
|
I guess the |
concussious
force-pushed
the
networking.7
branch
2 times, most recently
from
3736f30 to
cf560df
Compare
concussious
changed the title
concussious
added a commit
to concussious/freebsd-src
that referenced
this pull request
Jul 8, 2024
+ service routing restart breaks on dhcp + change my copyright from inbox to home Fixes: 75eda00 MFC after: 3 days Pointy hat: me Reported by: Graham Perrin Reviewed by: zlei Pull Request: github.com/freebsd/pull/1316
concussious
added a commit
to concussious/freebsd-src
that referenced
this pull request
Jul 8, 2024
+ service routing restart breaks on dhcp + change my copyright from inbox to home Fixes: 75eda00 MFC after: 3 days Pointy hat: me Reported by: Graham Perrin, zlei Pull Request: freebsd#1316
|
I don't want to break 50 chr limit. Thanks. |
|
I'll land this later after I test out my multiple PR CI landing script. |
concussious
added a commit
to concussious/freebsd-src
that referenced
this pull request
Jul 12, 2024
+ service routing restart breaks on dhcp + change my copyright from inbox to home Fixes: 75eda00 MFC after: 3 days Pointy hat: me Reported by: Graham Perrin, zlei Reviewed by: imp Pull Request: freebsd#1316
concussious
force-pushed
the
networking.7
branch
from
e629d6b to
6c2d29d
Compare
|
Changed it myself to save you some typing, thank you. |
bsdimp
pushed a commit
to concussious/freebsd-src
that referenced
this pull request
Jul 13, 2024
+ service routing restart breaks on dhcp + change my copyright from inbox to home Fixes: 75eda00 MFC after: 3 days Reported by: Graham Perrin, zlei Reviewed by: imp Pull Request: freebsd#1316
bsdimp
force-pushed
the
networking.7
branch
2 times, most recently
from
3cfc78f to
a6ca6df
Compare
+ service routing restart breaks on dhcp + change my copyright from inbox to home Fixes: 75eda00 MFC after: 3 days Reported by: Graham Perrin, zlei Reviewed by: imp Pull Request: freebsd#1316
This code is using the vnode after it has been released and causing a panic when a p9fs shared volume is unmounted. In fact, it seems like it's just duplicated code left behind from a bad merge. PR: 279887 Reported by: Michael Dexter Reviewed by: imp Pull Request: freebsd#1323
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Oct 30, 2024
+ service routing restart breaks on dhcp + change my copyright from inbox to home Fixes: 75eda00 MFC after: 3 days Reported by: Graham Perrin, zlei Reviewed by: imp Pull Request: freebsd/freebsd-src#1316
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
service routing restartisn't necessary and actually breaks routing.Fixes: 75eda00
MFC after: 3 days
Reported by: Graham Perrin