ps3disk.c: Rewrite ps3disk_transfer #1414
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While I'm not sure about the contents of the patch, permissions seem to change from 644 to 755. C source files should definitely be 644. |
|
Fixed, thanks. |
amotin
reviewed
Sep 11, 2024
|
This may be ready, but I think @amotin 's comments need a response at the very least. |
|
I think at the least, we should remove the assert since we have code to handle when it fails and we usually do one or the other. |
|
There is a CI failure: While in the end, there are no execute permissions for source files, one of your commits introduces those and then another one removes it. Can you squash those commits so that there are no execute permissions set at all? |
aomsin2526
force-pushed
the
ps3-ps3disk-transfer
branch
from
2ff36f6
to
1b897fa
Compare
|
Should be good now |
This function is bugged since the beginning, but it never hit because its variable doesn't allow. However, since commit a77e1f0 it happen now. First, it assume that ds_len will always equal to real user requested size. So it being used for sector count calculation. This is no longer true, and will fail if attempt to read last few sectors. Use bp->bio_length instead. Second, this being a loop is pointless because nsegs will never be > 1 as specified at bus_dma_tag_create() call. And all it doing is to repeat very same command again but with different ds_addr. Since bio_driver2 tag ident pointer are being reused, the result will be discarded at ps3disk_intr(). Signed-off-by: Chattrapat Sangmanee <aomsin27@hotmail.co.th>
aomsin2526
force-pushed
the
ps3-ps3disk-transfer
branch
from
1b897fa
to
282ebf8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is bugged since the beginning, but it never hit because its variable doesn't allow.
However, since commit a77e1f0 it happen now.
First, it assume that ds_len will always equal to real user requested size. So it being used for sector count calculation.
This is no longer true, and will fail if attempt to read last few sectors.
Use bp->bio_length instead.
Second, this being a loop is pointless because nsegs will never be > 1 as specified at bus_dma_tag_create() call.
And all it doing is to repeat very same command again but with different ds_addr. Since bio_driver2 tag ident pointer are being reused, the result will be discarded at ps3disk_intr().