powerpc/busdma_machdep.c: Limit sgsize to buflen #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same as #1414 |
|
Thanks. |
|
@mhorne , this is maybe fallout from your earlier commit, and if it is correct it is probably applicable to other architectures such as RISC-V and arm64 as well. |
Indeed, I have a piece of RISC-V hardware that exhibits the problem and requires the same fix. (As opposed to the hardware that required the change at fault, a77e1f0). I require a little more time to be sure of what exactly is going wrong, but rest assured I am looking into it and will be able to take action on this PR soon. |
Before commit a77e1f0, total sum of ds_len will always equal to user requested size (buflen), so user assume that this will always be true and used it as reference. Now since this is no longer true, it causes severe memory corruption. By simply limit sgsize of last segment to buflen will fix it. Signed-off-by: Chattrapat Sangmanee <aomsin27@hotmail.co.th>
aomsin2526
force-pushed
the
ps3-busdma
branch
from
5c2e675
to
ac25540
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before commit a77e1f0, total sum of ds_len will always equal to user requested size (buflen), so user assume that this will always be true and used it as reference. (example #1414)
Now since this is no longer true, it causes severe memory corruption.
By simply limit sgsize of last segment to buflen will fix it.