Unneeded dependency: macholib

[Enchufa2]

Is macholib required? I was trying to package this for Fedora, and I was confused, because the build instructions do not include this library, but the poetry lock lists it.

[truthinhoney]

Yes, macholib is required.

[Enchufa2]

Sorry to insist, but are we sure? Because a grep shows that this is only referenced in poetry.lock and pyproject.toml, but nowhere else.

[truthinhoney]

I asked https://fedoraproject.org/wiki/User:Ankursinha and he told me that it should be required since it is mentioned in pyproject.toml, but he also said to wait for upstream developer to give proper answer.

Honestly I barely know anything about packaging or programming so I am not certain that it is required lol.

Thank you for attempting to package this for Fedora! :)

[gmarmstrong]

I believe macholib is just an unused remnant from when pyobjc-core (which depends on macholib) was added. macholib was automatically added to the Pipfile.lock, and it looks like it made its way into the pyproject.toml dependencies when the switch was made from pipenv to poetry. The pyobjc-core dependency was eventually removed, but macholib remained. Removing it from the poetry environment now doesn't cause any problems, and I can even rebuild the container and macOS app on a Mac without macholib. The entry (if kept at all) should probably be something like:

[tool.poetry.dev-dependencies]
macholib = {version = "*", platform = "darwin", optional=true}

I'm not a maintainer, so take that with a grain of salt.

[gmarmstrong]

Ah, macholib is also a dependency of pyinstaller, which is only needed for platform = "darwin" (macOS). Found that out through poetry show --tree. Still, no need for it to be explicitly listed as a dangerzone dependency.