-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prune dependencies #170
Prune dependencies #170
Conversation
A few more deps that can be removed:
@gmarmstrong do you think you could remove these as well and rebase it with main so it can be merged? |
Oops, apparently "sync fork" does a merge instead of a rebase. Excuse me while I force-push this mistake away... |
7c1594d
to
bc1c5ff
Compare
Done! ✅ |
Thanks a lot!
No worries! You won't beat my struggle with the Github UX where I wanted to open a PR against your fork and accidentally instead opened against the main one, twice! 😅 |
It seems four commits are included from the main branch. I'll try to understand what's going on tomorrow. |
It should be fixed now! 🙂 I basically did the following to correct it:
I'm just waiting for Micah's response regarding WMI before merging. Thanks again for your contribution! |
Just removes two unused dependencies (
requests
andmacholib
). Fixes #145.