New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI runs Rust-specific lint/test jobs #6814

Closed

Tracked by

legoktm opened this issue May 17, 2023 · 0 comments · Fixed by #6828

Closed

Tracked by

CI runs Rust-specific lint/test jobs #6814

legoktm opened this issue May 17, 2023 · 0 comments · Fixed by #6828

Assignees

Labels

Rust

Member

legoktm commented May 17, 2023 •

edited

Loading

We are introducing Rust code for the first time as part of the Sequoia work and need to set up CI checks. For the first step we should:

Run cargo clippy, with warnings causing failures
Run cargo test
Run maturin build, so we know that it builds/compiles with pyO3.

The text was updated successfully, but these errors were encountered:

legoktm mentioned this issue

Use Sequoia-PGP instead of gpg/pretty_bad_protocol #6399

Closed

14 tasks

legoktm changed the title ~~CI runs Rust-specific lint/test jobs (done in oxidize branch)~~ CI runs Rust-specific lint/test jobs

legoktm added the Rust label

cfm added this to SecureDrop dev cycle

zenmonkeykstop moved this to Cycle Backlog in SecureDrop dev cycle

legoktm added a commit that referenced this issue


          Add Rust checks to Makefile and CircleCI

ac4a012

These lint and test solely the Rust code (no Python). The following
tools are enabled:

* rustfmt: code formatting (like black)
* clippy: linting (like flake8+pylint+mypy)
* cargo test: Rust test suite

Running maturin to verify the Python integration will happen in the next
commit, when it's hooked into the development environment.

Refs #6814.

legoktm added a commit that referenced this issue


          Build and install redwood wheel in all developer tooling

27c5c76

We need to compile Rust code before we can launch the development
environment and run tests.

Add a build_redwood step to `securedrop/bin/dev-deps` that uses maturin
to build a wheel and install it into the securedrop-app-code virtualenv.

maturin is only needed at build time, so it is pinned in a new
`build-requirements.txt`

Fixes #6814.
Fixes #6816.

legoktm mentioned this issue

Add "redwood" Sequoia Rust/Python bridge #6828

Merged

7 tasks

legoktm self-assigned this

legoktm moved this from Cycle Backlog to In Progress in SecureDrop dev cycle

legoktm added a commit that referenced this issue


          Add Rust checks to Makefile and CircleCI

40d0efe

These lint and test solely the Rust code (no Python). The following
tools are enabled:

* rustfmt: code formatting (like black)
* clippy: linting (like flake8+pylint+mypy)
* cargo test: Rust test suite

Running maturin to verify the Python integration will happen in the next
commit, when it's hooked into the development environment.

Refs #6814.

legoktm added a commit that referenced this issue


          Build and install redwood wheel in all developer tooling

42f4fe8

We need to compile Rust code before we can launch the development
environment and run tests.

Add a build_redwood step to `securedrop/bin/dev-deps` that uses maturin
to build a wheel and install it into the securedrop-app-code virtualenv.

maturin is only needed at build time, so it is pinned in a new
`build-requirements.txt`

Fixes #6814.
Fixes #6816.

legoktm added a commit that referenced this issue


          Add Rust checks to Makefile and CircleCI

392a589

These lint and test solely the Rust code (no Python). The following
tools are enabled:

* rustfmt: code formatting (like black)
* clippy: linting (like flake8+pylint+mypy)
* cargo test: Rust test suite

Running maturin to verify the Python integration will happen in the next
commit, when it's hooked into the development environment.

Refs #6814.

legoktm added a commit that referenced this issue


          Build and install redwood wheel in all developer tooling

5d5708c

We need to compile Rust code before we can launch the development
environment and run tests.

Add a build_redwood step to `securedrop/bin/dev-deps` that uses maturin
to build a wheel and install it into the securedrop-app-code virtualenv.

maturin is only needed at build time, so it is pinned in a new
`build-requirements.txt`

Fixes #6814.
Fixes #6816.

legoktm moved this from In Progress to Ready For Review in SecureDrop dev cycle

legoktm added a commit that referenced this issue


          Add Rust checks to Makefile and CircleCI

dc9413a

These lint and test solely the Rust code (no Python). The following
tools are enabled:

* rustfmt: code formatting (like black)
* clippy: linting (like flake8+pylint+mypy)
* cargo test: Rust test suite

Running maturin to verify the Python integration will happen in the next
commit, when it's hooked into the development environment.

Refs #6814.

legoktm added a commit that referenced this issue


          Build and install redwood wheel in all developer tooling

We need to compile Rust code before we can launch the development
environment and run tests.

Add a build_redwood step to `securedrop/bin/dev-deps` that uses maturin
to build a wheel and install it into the securedrop-app-code virtualenv.

maturin is only needed at build time, so it is pinned in a new
`build-requirements.txt`

Fixes #6814.
Fixes #6816.

legoktm added a commit that referenced this issue


          Add Rust checks to Makefile and CircleCI

2b4c7f5

These lint and test solely the Rust code (no Python). The following
tools are enabled:

* rustfmt: code formatting (like black)
* clippy: linting (like flake8+pylint+mypy)
* cargo test: Rust test suite

Running maturin to verify the Python integration will happen in the next
commit, when it's hooked into the development environment.

Refs #6814.

legoktm added a commit that referenced this issue


          Build and install redwood wheel in all developer tooling

ba97ac1

We need to compile Rust code before we can launch the development
environment and run tests.

Add a build_redwood step to `securedrop/bin/dev-deps` that uses maturin
to build a wheel and install it into the securedrop-app-code virtualenv.

maturin is only needed at build time, so it is pinned in a new
`build-requirements.txt`

Fixes #6814.
Fixes #6816.

legoktm added a commit that referenced this issue


          Add Rust checks to Makefile and CircleCI

f6a0d6d

These lint and test solely the Rust code (no Python). The following
tools are enabled:

* rustfmt: code formatting (like black)
* clippy: linting (like flake8+pylint+mypy)
* cargo test: Rust test suite

Running maturin to verify the Python integration will happen in the next
commit, when it's hooked into the development environment.

Refs #6814.

legoktm added a commit that referenced this issue


          Build and install redwood wheel in all developer tooling

de44480

We need to compile Rust code before we can launch the development
environment and run tests.

Add a build_redwood step to `securedrop/bin/dev-deps` that uses maturin
to build a wheel and install it into the securedrop-app-code virtualenv.

maturin is only needed at build time, so it is pinned in a new
`build-requirements.txt`

Fixes #6814.
Fixes #6816.

legoktm added a commit that referenced this issue


          Add Rust checks to Makefile and CircleCI

1563ceb

These lint and test solely the Rust code (no Python). The following
tools are enabled:

* rustfmt: code formatting (like black)
* clippy: linting (like flake8+pylint+mypy)
* cargo test: Rust test suite

Running maturin to verify the Python integration will happen in the next
commit, when it's hooked into the development environment.

Refs #6814.

legoktm added a commit that referenced this issue


          Build and install redwood wheel in all developer tooling

c636c14

We need to compile Rust code before we can launch the development
environment and run tests.

Add a build_redwood step to `securedrop/bin/dev-deps` that uses maturin
to build a wheel and install it into the securedrop-app-code virtualenv.

maturin is only needed at build time, so it is pinned in a new
`build-requirements.txt`

Fixes #6814.
Fixes #6816.

cfm closed this as completed in #6828

github-project-automation bot moved this from Ready For Review to Done in SecureDrop dev cycle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment