Run make lint and other simple jobs in GitHub Actions
#6969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I split out the first mypy speedup commit to a separate PR: #6971. |
1 task
legoktm
force-pushed
the
gha-lint
branch
3 times, most recently
from
0b60b2e
to
ec4f1ff
Compare
This is a ground-up rewrite of the "lint" job instead of porting it from CircleCI. It will be much faster since it doesn't try to spin up a Docker container and work through our various unnecessary caching layers. It does literally the bare minimum to run lints. The CircleCI lint job needs to remain for now because it's super intertwined with everything else.
legoktm
force-pushed
the
gha-lint
branch
2 times, most recently
from
bef1783
to
d5327ee
Compare
legoktm
changed the title
make lint job in GitHub Actionsmake lint and other simple jobs in GitHub Actions
leee
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
lint
This is a ground-up rewrite of the "lint" job instead of porting it from
CircleCI. It will be much faster since it doesn't try to spin up a
Docker container and work through our various unnecessary caching
layers. It does literally the bare minimum to run lints.
The CircleCI lint job needs to remain for now because it's super
intertwined with everything else.
part 2
Migrate rust, rust-security and updater-gui-tests since they're pretty simple.
Testing