Point mypy at redwood type stub directly #6971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of the possibly slow process of compiling redwood and installing it into the virtualenv, we can just point mypy at the stub directly. (For some reason mypy wanted us to use an explicit "tuple" type.) Notably this means you can run the lint process without needing a Rust toolchain installed. Refs #6831.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Instead of the possibly slow process of compiling redwood and installing it into the virtualenv, we can just point mypy at the stub directly. (For some reason mypy wanted us to use an explicit "tuple" type.)
Notably this means you can run the lint process without needing a Rust toolchain installed.
Refs #6831.
Testing
How should the reviewer test this PR?
rm -rf targetand then runmake typelint, it should not compile Rust code.Deployment
Any special considerations for deployment? No
Checklist
make lint) and tests (make test) pass in the development container