Support deploy for partial rollout #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Google recently documented this parameter to the `publish` call; this adds support for it.
fregante
reviewed
May 30, 2024
| `${rootURI}/chromewebstore/v1.1/items/${id}/publish?publishTarget=${target}`; | ||
| const publishURI = (id, target, deployPercentage) => ( | ||
| `${rootURI}/chromewebstore/v1.1/items/${id}/publish?publishTarget=${target}` | ||
| + (deployPercentage == undefined ? '' : `&deployPercentage=${deployPercentage}`) |
There was a problem hiding this comment.
Could you alter this function to build the URL via new URL() so you can add parameters via url.searchParams.set()?
| @@ -6,8 +6,10 @@ const rootURI = 'https://www.googleapis.com'; | |||
| export const refreshTokenURI = 'https://www.googleapis.com/oauth2/v4/token'; | |||
| const uploadExistingURI = id => | |||
| `${rootURI}/upload/chromewebstore/v1.1/items/${id}`; | |||
| const publishURI = (id, target) => | |||
| `${rootURI}/chromewebstore/v1.1/items/${id}/publish?publishTarget=${target}`; | |||
| const publishURI = (id, target, deployPercentage) => ( | |||
There was a problem hiding this comment.
Functions shouldn't accept more than 1 optional parameter, can you turn this into an object? {id, target, deployPercentage}
| @@ -61,10 +63,10 @@ class APIClient { | |||
| return response; | |||
| } | |||
|
|
|||
| async publish(target = 'default', token = this.fetchToken()) { | |||
| async publish(target = 'default', token = this.fetchToken(), deployPercentage = undefined) { | |||
There was a problem hiding this comment.
Same goes here, this can be changed to a single object: {target, token, deployPercentage}
I'll release a breaking version after this
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google recently documented a new
deployPercentageparameter to thepublishAPI call.This allows using partial rollout on extensions published via the API.