disable ffuplink-interface during initial setup #185
Conversation
On a fresh installed system, there is no valid setup of ffuplink. So we disable this interface, till it's configured by some uplink-preset.
The default of this interface is disabled, so we must enable it after it's setup.
|
I just did a test. I installed the tunneldigger version. In the wizard, I selected mesh only (sharenet=0). I also connect the wan port to the internet. After reboot, the tunneldigger interface builds. That means that disabled=0 for the ffuplink interface. I set up a second node with the no-tunnel version. In the wizard, I again selected mesh only. I also connected the wan port to ethernet. After reboot, the dhcp interface builds. Both nodes see each other as smart gateways. There is no internet. Possibly, instead of setting disabled=0 in the uci-defaults, it shold go in the wizard. Maybe where sharenet is set to 1. |
|
An alternative to this PR has been created (#190) |
|
@SvenRoederer can we close this PR and use #190 instead? |
|
@pmelange essentially the difference between this PR and PR #190 is the place where the interface will be enabled.
PR #190 relies on the wizard:
It's hard to decide for one as the best solution ... |
Try the tests described in #185 (comment). After the wizard is ran and "share internet" is not enabled, then the node should not announce a smart gateway. PR #185 Fails this test. PR #190 does not fail this test. |
The ffuplink interface is disabled by default on a fresh install. During the course of running the wizard, the user must select if they want to share their internet connection or not. If the user decides to share their internet, then the ffuplink interface shall be enabled (setting disabled=0). This addresses freifunk-berlin/firmware#603
…cted" This reverts commit 1aebe45, as it puts code related to "shareInternet-Settings" in the wireless.lua-file.
When the user is on the "shareInternet"-page he must have selected to share his uplink. As he wants to share the uplink, we enable this interface here.
This reverts commit a548568, as we enable the ffuplink-interface in the ffwizard when reachjing the "sharenet"-page. On manually configured routers this interface must be enabled in the configuration.
From the logic perspective it should be:
By writing this, I feel we should rework this system, as soon as we implement the "common Image for dynamical selection of uplink-type". @pmelange I suggest to use this PR, as it now combines your suggestion with enabling the ffuplink-interface in the wizard and also keeps the idea to have the uplink-packages enable the uplink. This way we can later revert individual changes, as we need them. |
this is not needed anymore, sine we use git-autoversioning on master.
|
Quite honestly, do whatever you want with this. I am no longer developing for the freifunk firmware. |
On a fresh installed system, there is no valid setup of ffuplink. So we disable this interface, till it's configured by some uplink-preset.
The advantage of this change s, that an unconfigured ffuplink (as so uplink-preset was installed for manual configuration) will not cause any unintended sideeffects.
This code ha been tested on the SAm0815_experimental branches since some time.