Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: dependabot.yml #14

Merged
merged 2 commits into from
Nov 1, 2021
Merged

Added: dependabot.yml #14

merged 2 commits into from
Nov 1, 2021

Conversation

GoliathLabs
Copy link
Member

The dependabot.yml file has been added so that we no longer have to worry about dependency updates, since dependabot checks for them monthly. However, for this we should enable issues.

Copy link
Member

@DasSkelett DasSkelett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, maybe put a new line at the end, but that's not a blocker. I'm not in the salt-stack team so I won't receive the review pings, but I've got notifications turned on for this repository anyway.

.github/dependabot.yml Outdated Show resolved Hide resolved
@DasSkelett DasSkelett merged commit 38a40cc into freifunkMUC:master Nov 1, 2021
@DasSkelett
Copy link
Member

DasSkelett commented Nov 1, 2021

https://github.com/freifunkMUC/wg-access-server/runs/4071977549

Dependabot couldn't parse the config file at .github/dependabot.yml. The error raised was:
(<unknown>): found character that cannot start any token while scanning for the next token at line 9 column 17

I believe that's the @ which is not allowed to start a string in YAML, looking at https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/configuration-options-for-dependency-updates#reviewers I think we're supposed to leave the @ out

@GoliathLabs
Copy link
Member Author

Hmm. Interesting. Maybe we should add you as the reviewer and assignee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants