fix(tests): fix TestHealthReporterRetry, TestValidateTokenStatic #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: SRX-AHGZTR Ref: SRX-TI3JNJ - TestHealthReporterRetry: There's a background job going on in the ReportHealth function which should be completed before we check the expectations. Sometimes it may be left behind(It's pretty rare). So, if we wait several miliseconds and then do the checks, it would solve the problem. - TestValidateTokenStatic: The issue is related to the underlying library `golang-jwt` that we use. Since we shouldn't test the libraries it's ok to remove the test.
AminSlk
force-pushed
the
am/fix-flaky-tests
branch
from
3be068a to
c172979
Compare
…tcher for errors Ref: SRX-AHGZTR
sven-urbanski-freiheit-com
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: SRX-AHGZTR
Ref: SRX-TI3JNJ
golang-jwt. We shouldn't test the error messages that are returned by the library not us.