Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): fix TestHealthReporterRetry, TestValidateTokenStatic #2038

Merged
merged 4 commits into from
Oct 15, 2024
Merged

fix(tests): fix TestHealthReporterRetry, TestValidateTokenStatic #2038

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c172979
fix(tests): fix TestHealthReporterRetry, TestValidateTokenStatic
AminSlk Oct 14, 2024
e131053
fix(ci): added a channel for backoffs in health test, added prefix ma…
AminSlk Oct 14, 2024
80126bd
fix(ci): add backOffChanLength as a parameter in TestHealthReporterRetry
AminSlk Oct 14, 2024
354c580
fix(tests): fix healthReporterReady test for waiting on backoff
AminSlk Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions pkg/auth/azure_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,6 @@ func TestValidateTokenStatic(t *testing.T) {
ExpectedError error
noInit bool
}{
{
Name: "Not a token",
Token: "asdf",
ExpectedError: errMatcher{"Failed to parse the JWT.\nError: token is malformed: token contains an invalid number of segments"},
AminSlk marked this conversation as resolved.
Show resolved Hide resolved
},
{
Name: "Not initialized",
Token: "asdf",
Expand Down
1 change: 1 addition & 0 deletions pkg/setup/health_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,7 @@ func TestHealthReporterRetry(t *testing.T) {
for _, st := range tc.Steps {
stepCh <- st
<-stateChange
time.Sleep(500 * time.Millisecond)
sven-urbanski-freiheit-com marked this conversation as resolved.
Show resolved Hide resolved
ready := hs.IsReady("a")
if st.ExpectReady != ready {
t.Errorf("expected ready status to %t but got %t", st.ExpectReady, ready)
Expand Down
Loading