-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(upgrade): v1.8.0 to v1.9.0 #2099
chore(upgrade): v1.8.0 to v1.9.0 #2099
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
e9f33c4
to
ba953e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parsed through changes , since most are upgrade related , so looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 LGTM!
e8ac927
to
21a07b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Added 1 comment.
- To be able to use Multi Block Migrations we might need to look into using poll instead of on_initialize
- Added host function to clawback POV requires node upgrades before enabling from runtime
@@ -668,7 +668,7 @@ fn migration_to_v2_should_work_as_expected() { | |||
|
|||
let old_count = v2::old::Messages::<Test>::iter().count(); | |||
let new_count = MessagesV2::<Test>::iter().count(); | |||
let current_version = MessagesPallet::current_storage_version(); | |||
let current_version = MessagesPallet::in_code_storage_version(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to ensure these are exactly the same values. If not it would brick the chain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out. I forgot to include it in the notable changes section of the PR. It appears to be a rename, and I’ll make sure to add it to the notable changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Pulled/built branch
- Ran unit tests
- Ran e2e tests
Looks good!
You are right. I have created a ticket so we can allocate time to investigate where we can move the on_initialize functions to poll. |
2f9f0e2
to
8d2f7a5
Compare
- Upgrade Polkadot-sdk to v.1.9.0. - Update weights to reflect the new version. Notable Changes: - [System Callabacks](paritytech/polkadot-sdk#1781) - [Remove of pallet pallet::getter](paritytech/polkadot-sdk#3456) - [Add storage_proof_size host function](paritytech/polkadot-sdk#3002) - [Rename of storage version function](https://github.com/paritytech/polkadot-sdk/pull/1554/files#diff-01dc4f43df9baa537f30c6b369525715d596a3068944f38458e9f160d5412d58R306) For more details, please refer to: [Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.9.0)
8d2f7a5
to
23a0e9f
Compare
Notable Changes:
For more details, please refer to:
Release Notes