Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(upgrade): v1.8.0 to v1.9.0 #2099

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

enddynayn
Copy link
Collaborator

@enddynayn enddynayn commented Jul 25, 2024

  • Upgrade Polkadot-sdk to v.1.9.0.
  • Update weights to reflect the new version.

Notable Changes:

For more details, please refer to:

Release Notes

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
pallets/messages/src/migration/v2.rs 85.71% <100.00%> (ø)
pallets/schemas/src/migration/v4.rs 41.53% <100.00%> (ø)

... and 6 files with indirect coverage changes

@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.8.0-to-v1.9.0-issue-1922 branch 2 times, most recently from e9f33c4 to ba953e5 Compare July 26, 2024 16:11
@enddynayn enddynayn changed the title Chore/upgrade polkadot v1.8.0 to v1.9.0 issue 1922 chore(upgrade): v1.8.0 to v1.9.0 Jul 26, 2024
@enddynayn enddynayn marked this pull request as ready for review July 26, 2024 16:12
@enddynayn enddynayn requested a review from wilwade as a code owner July 26, 2024 16:12
@enddynayn enddynayn requested review from aramikm, saraswatpuneet, JoeCap08055 and claireolmstead and removed request for wilwade July 26, 2024 16:14
Copy link
Collaborator

@saraswatpuneet saraswatpuneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parsed through changes , since most are upgrade related , so looks good to me

Copy link
Collaborator

@claireolmstead claireolmstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 LGTM!

@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented and removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Jul 26, 2024
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.8.0-to-v1.9.0-issue-1922 branch from e8ac927 to 21a07b5 Compare July 26, 2024 17:27
Copy link
Collaborator

@aramikm aramikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Added 1 comment.

  • To be able to use Multi Block Migrations we might need to look into using poll instead of on_initialize
  • Added host function to clawback POV requires node upgrades before enabling from runtime

@@ -668,7 +668,7 @@ fn migration_to_v2_should_work_as_expected() {

let old_count = v2::old::Messages::<Test>::iter().count();
let new_count = MessagesV2::<Test>::iter().count();
let current_version = MessagesPallet::current_storage_version();
let current_version = MessagesPallet::in_code_storage_version();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to ensure these are exactly the same values. If not it would brick the chain.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. I forgot to include it in the notable changes section of the PR. It appears to be a rename, and I’ll make sure to add it to the notable changes.

https://github.com/paritytech/polkadot-sdk/pull/1554/files#diff-01dc4f43df9baa537f30c6b369525715d596a3068944f38458e9f160d5412d58R306

@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Jul 26, 2024
Copy link
Collaborator

@JoeCap08055 JoeCap08055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Pulled/built branch
  • Ran unit tests
  • Ran e2e tests
    Looks good!

@enddynayn
Copy link
Collaborator Author

Overall looks good. Added 1 comment.

  • To be able to use Multi Block Migrations we might need to look into using poll instead of on_initialize
  • Added host function to clawback POV requires node upgrades before enabling from runtime

You are right. I have created a ticket so we can allocate time to investigate where we can move the on_initialize functions to poll.

#2098

@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.8.0-to-v1.9.0-issue-1922 branch from 2f9f0e2 to 8d2f7a5 Compare July 26, 2024 18:31
@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Jul 26, 2024
- Upgrade Polkadot-sdk to v.1.9.0.
- Update weights to reflect the new version.

Notable Changes:
- [System Callabacks](paritytech/polkadot-sdk#1781)
- [Remove of pallet pallet::getter](paritytech/polkadot-sdk#3456)
- [Add storage_proof_size host function](paritytech/polkadot-sdk#3002)
- [Rename of storage version function](https://github.com/paritytech/polkadot-sdk/pull/1554/files#diff-01dc4f43df9baa537f30c6b369525715d596a3068944f38458e9f160d5412d58R306)

For more details, please refer to:

[Release
Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.9.0)
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.8.0-to-v1.9.0-issue-1922 branch from 8d2f7a5 to 23a0e9f Compare July 26, 2024 18:34
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Jul 26, 2024
@enddynayn enddynayn merged commit 21f1bde into main Jul 26, 2024
27 checks passed
@enddynayn enddynayn deleted the chore/upgrade-polkadot-v1.8.0-to-v1.9.0-issue-1922 branch July 26, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metadata-changed Metadata has changed since the latest full release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants