Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed pallet::getter usage from pallet-collective #3456

Merged
merged 10 commits into from
Mar 5, 2024
Merged

Removed pallet::getter usage from pallet-collective #3456

merged 10 commits into from
Mar 5, 2024

Conversation

muraca
Copy link
Contributor

@muraca muraca commented Feb 23, 2024 •
edited
Loading

Part of #3326
This one is easier as all the storage items are public.

@ggwpez @kianenigma @shawntabrizi

polkadot address: 12poSUQPtcF1HUPQGY3zZu2P8emuW9YnsPduA4XG3oCEfJVp

@muraca
removed pallet::getter from pallet-collective
6368635 
Signed-off-by: Matteo Muraca <mmuraca247@gmail.com>
@muraca
fixed pallet-alliance tests
2e33245 
Signed-off-by: Matteo Muraca <mmuraca247@gmail.com>
@muraca
updated collectives-westend-runtime and kitchensink-runtime
2afbba2 
Signed-off-by: Matteo Muraca <mmuraca247@gmail.com>
@muraca
cargo fmt on pallet-collective
ef2f94c 
Signed-off-by: Matteo Muraca <mmuraca247@gmail.com>
@muraca
prdoc for paritytech#3456
0fbca20 
Signed-off-by: Matteo Muraca <mmuraca247@gmail.com>
@muraca
cargo fmt on kitchensink-runtime
19cb699 
Signed-off-by: Matteo Muraca <mmuraca247@gmail.com>
@muraca muraca marked this pull request as ready for review February 23, 2024 10:30
@muraca muraca requested a review from a team as a code owner February 23, 2024 10:30
@muraca
Copy link
Contributor Author

muraca commented Feb 23, 2024

In the prdoc i didn't mention pallet-alliance, where I only had to update tests. Should I?

@muraca muraca mentioned this pull request Feb 23, 2024
Open
63 tasks
@ggwpez ggwpez added the T2-pallets This PR/Issue is related to a particular pallet. label Feb 23, 2024
@liamaharon
Copy link
Contributor

In the prdoc i didn't mention pallet-alliance, where I only had to update tests. Should I?

Not necessary, doesn't impact anyone downstream

liamaharon
liamaharon approved these changes Mar 3, 2024
View reviewed changes
prdoc/pr_3456.prdoc Outdated Show resolved Hide resolved
prdoc/pr_3456.prdoc Outdated Show resolved Hide resolved
@muraca @liamaharon
improved prdoc
030fb55 
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
@muraca muraca changed the title removed pallet::getter from pallet-collective Removed pallet::getter usage from pallet-collective Mar 3, 2024
@liamaharon
Copy link
Contributor

bot fmt

@command-bot
Copy link

command-bot bot commented Mar 3, 2024 •
edited
Loading

@liamaharon https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5418161 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 13-90875c37-a8fe-4c44-afdb-492c647481dd to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Mar 3, 2024

@liamaharon Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5418161 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5418161/artifacts/download.

@kianenigma kianenigma added this pull request to the merge queue Mar 5, 2024
@muraca
Copy link
Contributor Author

muraca commented Mar 5, 2024

Thanks! I will be working again on #1445 in the next few days

Merged via the queue into paritytech:master with commit a71f018 Mar 5, 2024
126 of 130 checks passed
@liamaharon
Copy link
Contributor

/tip small

@substrate-tip-bot substrate-tip-bot
Copy link

@liamaharon A referendum for a small (20 DOT) tip was successfully submitted for @muraca (12poSUQPtcF1HUPQGY3zZu2P8emuW9YnsPduA4XG3oCEfJVp on polkadot).

Referendum number: 579.
tip

@substrate-tip-bot substrate-tip-bot
Copy link

The referendum has appeared on Polkassembly.

bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@muraca @liamaharon @kianenigma
Removed pallet::getter usage from pallet-collective (paritytech#3456
f6cd78c 
)

Part of paritytech#3326 
This one is easier as all the storage items are public. 

@ggwpez @kianenigma @shawntabrizi

---------

Signed-off-by: Matteo Muraca <mmuraca247@gmail.com>
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
Co-authored-by: command-bot <>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
This was referenced Jun 5, 2024
Closed
Closed
Closed
Closed
enddynayn added a commit to frequency-chain/frequency that referenced this pull request Jul 26, 2024
@enddynayn
chore(upgrade): v1.8.0 to v1.9.0
ba953e5 
- Upgrade Polkadot-sdk to v.1.8.0.
- Update weights to reflect the new version.

Notable Changes:
- [System Callabacks](paritytech/polkadot-sdk#1781)
- [Remove of pallet pallet::getter](paritytech/polkadot-sdk#3456)
- [Add storage_proof_size host function](paritytech/polkadot-sdk#3002)

For more details, please refer to:

[Release
Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.9.0)
@enddynayn enddynayn mentioned this pull request Jul 26, 2024
Merged
enddynayn added a commit to frequency-chain/frequency that referenced this pull request Jul 26, 2024
@enddynayn
chore(upgrade): v1.8.0 to v1.9.0
21a07b5 
- Upgrade Polkadot-sdk to v.1.8.0.
- Update weights to reflect the new version.

Notable Changes:
- [System Callabacks](paritytech/polkadot-sdk#1781)
- [Remove of pallet pallet::getter](paritytech/polkadot-sdk#3456)
- [Add storage_proof_size host function](paritytech/polkadot-sdk#3002)

For more details, please refer to:

[Release
Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.9.0)
enddynayn added a commit to frequency-chain/frequency that referenced this pull request Jul 26, 2024
@enddynayn
chore(upgrade): v1.8.0 to v1.9.0
8d2f7a5 
- Upgrade Polkadot-sdk to v.1.8.0.
- Update weights to reflect the new version.

Notable Changes:
- [System Callabacks](paritytech/polkadot-sdk#1781)
- [Remove of pallet pallet::getter](paritytech/polkadot-sdk#3456)
- [Add storage_proof_size host function](paritytech/polkadot-sdk#3002)
- [Rename of storage version function](https://github.com/paritytech/polkadot-sdk/pull/1554/files#diff-01dc4f43df9baa537f30c6b369525715d596a3068944f38458e9f160d5412d58R306)

For more details, please refer to:

[Release
Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.9.0)
enddynayn added a commit to frequency-chain/frequency that referenced this pull request Jul 26, 2024
@enddynayn
chore(upgrade): v1.8.0 to v1.9.0
23a0e9f 
- Upgrade Polkadot-sdk to v.1.9.0.
- Update weights to reflect the new version.

Notable Changes:
- [System Callabacks](paritytech/polkadot-sdk#1781)
- [Remove of pallet pallet::getter](paritytech/polkadot-sdk#3456)
- [Add storage_proof_size host function](paritytech/polkadot-sdk#3002)
- [Rename of storage version function](https://github.com/paritytech/polkadot-sdk/pull/1554/files#diff-01dc4f43df9baa537f30c6b369525715d596a3068944f38458e9f160d5412d58R306)

For more details, please refer to:

[Release
Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.9.0)
enddynayn added a commit to frequency-chain/frequency that referenced this pull request Jul 26, 2024
@enddynayn
chore(upgrade): v1.8.0 to v1.9.0 (#2099)
21f1bde 
- Upgrade Polkadot-sdk to v.1.9.0.
- Update weights to reflect the new version.

Notable Changes:
- [System
Callbacks](paritytech/polkadot-sdk#1781)
- [Remove of pallet
pallet::getter](paritytech/polkadot-sdk#3456)
- [Add storage_proof_size host
function](paritytech/polkadot-sdk#3002)
- [Rename of storage version
function](https://github.com/paritytech/polkadot-sdk/pull/1554/files#diff-01dc4f43df9baa537f30c6b369525715d596a3068944f38458e9f160d5412d58R306)

For more details, please refer to:

[Release
Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.9.0)
rustadot pushed a commit to rustadot/recurrency that referenced this pull request Sep 5, 2024
@enddynayn
chore(upgrade): v1.8.0 to v1.9.0 (#2099)
833b037 
- Upgrade Polkadot-sdk to v.1.9.0.
- Update weights to reflect the new version.

Notable Changes:
- [System
Callbacks](paritytech/polkadot-sdk#1781)
- [Remove of pallet
pallet::getter](paritytech/polkadot-sdk#3456)
- [Add storage_proof_size host
function](paritytech/polkadot-sdk#3002)
- [Rename of storage version
function](https://github.com/paritytech/polkadot-sdk/pull/1554/files#diff-01dc4f43df9baa537f30c6b369525715d596a3068944f38458e9f160d5412d58R306)

For more details, please refer to:

[Release
Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.9.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamaharon liamaharon liamaharon approved these changes

@kianenigma kianenigma kianenigma approved these changes

Assignees
No one assigned
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@muraca @liamaharon @kianenigma @ggwpez