The migration script for repo-config updates is not formatted for macOS #302
Labels
part:tooling
Affects the development tooling (CI, deployment, dependency management, etc.)
priority:❓
We need to figure out how soon this should be addressed
type:bug
Something isn't working
Comments
camille-bouvy-frequenz
added
priority:❓
keywordlabeler
bot
added
the
part:tooling
llucax
added a commit
to llucax/frequenz-repo-config-python
that referenced
this issue
Aug 29, 2024
The labeler configuration example was using a wrong key, it should be `all-globs-to-all-files` instead of `all-glob-to-all-file`. Note we use `perl` instead of `sed` in the migration script because it is more portable and we don't need to worry about the differences between the different `sed` implementations (refs frequenz-floss#302). Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
llucax
added a commit
to llucax/frequenz-repo-config-python
that referenced
this issue
Sep 12, 2024
The labeler configuration example was using a wrong key, it should be `all-globs-to-all-files` instead of `all-glob-to-all-file`. Note we use `perl` instead of `sed` in the migration script because it is more portable and we don't need to worry about the differences between the different `sed` implementations (refs frequenz-floss#302). Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
llucax
added a commit
to llucax/frequenz-repo-config-python
that referenced
this issue
Sep 12, 2024
The labeler configuration example was using a wrong key, it should be `all-globs-to-all-files` instead of `all-glob-to-all-file`. Note we use `perl` instead of `sed` in the migration script because it is more portable and we don't need to worry about the differences between the different `sed` implementations (refs frequenz-floss#302). Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
github-merge-queue bot
pushed a commit
that referenced
this issue
Sep 12, 2024
The labeler configuration example was using a wrong key, it should be `all-globs-to-all-files` instead of `all-glob-to-all-file`. Note we use `perl` instead of `sed` in the migration script because it is more portable and we don't need to worry about the differences between the different `sed` implementations (refs #302).
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 20, 2024
Since this is used to update Python projects, it is safe to assume Python will be available. Using Python is more portable, so hopefully the migration script will work more consistently across different OSes. Also update URL in the migration script to force users to adapt it to the version they need. Fixes #302.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
Update repo-config to v0.10.0 following the instructions described here does not work. Reason for this is that some commands are formatted differently in macOS (e.g.
sed -ineeds to be followed by an empty string).What did you expect instead?
Maybe having another script for the macOS users if that's an option
Affected version(s)
No response
Affected part(s)
Build script, CI, dependencies, etc. (part:tooling)
Extra information
No response
The text was updated successfully, but these errors were encountered: