-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the labeler configuration example #304
Conversation
Skipping release notes because it is too minor to be mentioned. |
Something funny is going on with the test, google protobuf complains about not being able to import something. WTF. |
We are getting this:
And then some internal import error. It is super weird because we are installing everything from scratch in the test, so there should be no version mismatch. I found this issue: But I guess that one could be really a version mismatch because the example code is provided pre-generated. |
I could reproduce locally. |
This might be something to do with dependencies interactions:
|
ece6c17
to
9796548
Compare
The labeler configuration example was using a wrong key, it should be `all-globs-to-all-files` instead of `all-glob-to-all-file`. Note we use `perl` instead of `sed` in the migration script because it is more portable and we don't need to worry about the differences between the different `sed` implementations (refs frequenz-floss#302). Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
9796548
to
e963e40
Compare
The labeler configuration example was using a wrong key, it should be
all-globs-to-all-files
instead ofall-glob-to-all-file
.Note we use
perl
instead ofsed
in the migration script because it is more portable and we don't need to worry about the differences between the differentsed
implementations (refs #302).