Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the labeler configuration example #304

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

llucax
Copy link
Contributor

@llucax llucax commented Aug 29, 2024

The labeler configuration example was using a wrong key, it should be all-globs-to-all-files instead of all-glob-to-all-file.

Note we use perl instead of sed in the migration script because it is more portable and we don't need to worry about the differences between the different sed implementations (refs #302).

@llucax llucax requested a review from a team as a code owner August 29, 2024 14:13
@llucax llucax self-assigned this Aug 29, 2024
@github-actions github-actions bot added the part:template Affects the cookiecutter template files label Aug 29, 2024
@llucax llucax added this to the v0.11.0 milestone Aug 29, 2024
@llucax llucax added cmd:skip-release-notes It is not necessary to update release notes for this PR and removed part:template Affects the cookiecutter template files labels Aug 29, 2024
@llucax
Copy link
Contributor Author

llucax commented Aug 29, 2024

Skipping release notes because it is too minor to be mentioned.

@llucax llucax enabled auto-merge August 29, 2024 14:14
@llucax llucax added part:docs Affects the documentation type:bug Something isn't working part:template Affects the cookiecutter template files labels Aug 29, 2024
@llucax llucax requested a review from Marenz August 29, 2024 14:14
Marenz
Marenz previously approved these changes Sep 2, 2024
@llucax
Copy link
Contributor Author

llucax commented Sep 2, 2024

Something funny is going on with the test, google protobuf complains about not being able to import something. WTF.

@llucax
Copy link
Contributor Author

llucax commented Sep 2, 2024

We are getting this:

UserWarning: Protobuf gencode version 5.27.2 is older than the runtime version 5.28.0 at frequenz/api/test/test.proto."

And then some internal import error. It is super weird because we are installing everything from scratch in the test, so there should be no version mismatch.

I found this issue:

But I guess that one could be really a version mismatch because the example code is provided pre-generated.

@llucax
Copy link
Contributor Author

llucax commented Sep 2, 2024

I could reproduce locally.

@llucax
Copy link
Contributor Author

llucax commented Sep 2, 2024

This might be something to do with dependencies interactions:

Because googleapis-common-protos==1.56.2 depends on protobuf>=3.15.0,<4.0.0.dev0 and you require googleapis-common-protos==1.56.2, we can conclude that you require protobuf>=3.15.0,<4.0.0.dev0.
      And because you require protobuf==4.25.3, we can conclude that the requirements are unsatisfiable.

The labeler configuration example was using a wrong key, it should be
`all-globs-to-all-files` instead of `all-glob-to-all-file`.

Note we use `perl` instead of `sed` in the migration script because it
is more portable and we don't need to worry about the differences
between the different `sed` implementations (refs frequenz-floss#302).

Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
@llucax llucax force-pushed the fix-labeler-example branch from 9796548 to e963e40 Compare September 12, 2024 07:31
@llucax llucax added this pull request to the merge queue Sep 12, 2024
Merged via the queue into frequenz-floss:v0.x.x with commit e499080 Sep 12, 2024
14 checks passed
@llucax llucax deleted the fix-labeler-example branch September 12, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd:skip-release-notes It is not necessary to update release notes for this PR part:docs Affects the documentation part:template Affects the cookiecutter template files type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants