Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path manipulation code assumes a Unix filesystem, fails on Windows #93

Closed
obi1kenobi opened this issue Jan 29, 2023 · 0 comments · Fixed by #94
Closed

Path manipulation code assumes a Unix filesystem, fails on Windows #93

obi1kenobi opened this issue Jan 29, 2023 · 0 comments · Fixed by #94

Comments

@obi1kenobi
Copy link
Contributor

Example failure:

Error: failed to make directory 'C:\Users\runneradmin\.cargo\registry/index\github.com-1ecc6299db9ec823': The system cannot find the path specified.
; class=Os (2)

Encountered in: obi1kenobi/cargo-semver-checks-action#21 (comment)

Appears to correspond to this bit of path manipulation code, which hardcodes a / path separator:

path.push("registry/index");

I also noticed another bit of code that also appears to hardcode a / path separator, though it's a bit tricky to replicate:

let path = base.join(".cargo/config.toml");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant