Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool fails on Windows #276

Closed
tonowak opened this issue Jan 9, 2023 · 4 comments · Fixed by #331
Closed

Tool fails on Windows #276

tonowak opened this issue Jan 9, 2023 · 4 comments · Fixed by #331
Labels
C-bug Category: doesn't meet expectations

Comments

@tonowak
Copy link
Collaborator

tonowak commented Jan 9, 2023

Related: obi1kenobi/cargo-semver-checks-action#21 (comment)

In short, there seems to be a path issue when comparing the crate with a baseline from the registry.

Proposed solution: try to reproduce the bug locally on Windows (if it somehow works, write a comment about it in the mentioned PR), fix it after reproducing and add an integration test (in the CI).

@tonowak tonowak added the C-bug Category: doesn't meet expectations label Jan 9, 2023
@obi1kenobi
Copy link
Owner

It might be a good idea to have at least one "positive" and one "negative" test (in terms of whether they're expected to find any semver issues) that run on each of our supported platforms and architectures (the ones we build binaries for).

@obi1kenobi
Copy link
Owner

Underlying cause: frewsxcv/rust-crates-index#93

@mgr0dzicki
Copy link
Collaborator

Unfortunately, the tool still fails on Windows when it is run from a precompiled binary. The problem occurs only when the .cargo/registry/index folder does not exist at the moment of running the binary (and this is exactly the case when it is launched inside the GitHub action). I've written the test with this specific scenario: #389.

@mgr0dzicki mgr0dzicki reopened this Feb 23, 2023
@mgr0dzicki mgr0dzicki removed their assignment Feb 23, 2023
@mgr0dzicki
Copy link
Collaborator

Completed by #389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: doesn't meet expectations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants