Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clip recording for Blink Mini and Doorbell camera models #946

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

mback2k
Copy link
Contributor

@mback2k mback2k commented Jun 9, 2024

Description:

Add missing camera model specific API service URLs.

See: https://community.home-assistant.io/t/start-recording-blink-camera-based-on-motion-or-ringing-of-my-ring-doorbell/382208/15?u=mback2k

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

Add missing camera model specific API service URLs.
Copy link

codecov bot commented Jun 9, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 99.2%. Comparing base (3057783) to head (23f450d).

Files Patch % Lines
blinkpy/camera.py 20.0% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             dev    #946     +/-   ##
=======================================
- Coverage   99.7%   99.2%   -0.6%     
=======================================
  Files          8       8             
  Lines       1490    1500     +10     
=======================================
+ Hits        1487    1489      +2     
- Misses         3      11      +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fronzbot fronzbot merged commit 8e6774b into fronzbot:dev Jun 9, 2024
12 of 13 checks passed
@fronzbot
Copy link
Owner

fronzbot commented Jun 9, 2024

Thanks again 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants