Bump blinkpy to 0.23.0

[mback2k]

Proposed change

From blinkpy-0.23.0:

• Added ability to get and set notification flags: Added ability to get and set notification flags fronzbot/blinkpy#949 (not used by Home Assistant integration at the moment)

From blinkpy-0.23.0b7 and blinkpy-0.23.0b8:

• Fix authentication due to Blink API changes: Fix verify endpoint fronzbot/blinkpy#925 and Pin issues fronzbot/blinkpy#941 and Add another get_homescreen() call after 2fa verification fronzbot/blinkpy#945
• Fix clip recording for Blink Mini and Doorbell: Fix clip recording for Blink Mini and Doorbell camera models fronzbot/blinkpy#946

From blinkpy-0.22.7:

• Fix camera battery_voltage and wifi_strength: Restore camera battery_voltage and wifi_strength fronzbot/blinkpy#877

Diff between v0.22.6 and v0.23.0 which unfortunately contains a lot of CI/CD related changes:
fronzbot/blinkpy@v0.22.6...v0.23.0 (maybe focus on .py files there)

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes the following issue happening nowadays on first authentication after integration setup:

2024-06-11 20:22:31.090 ERROR (MainThread) [blinkpy.auth] Login endpoint failed. Try again later.
2024-06-11 20:22:31.091 ERROR (MainThread) [blinkpy.auth] Unable to refresh token.

• This PR also adds support for triggering clip recordings with Blink Mini or Doorbell camera models:
  https://community.home-assistant.io/t/start-recording-blink-camera-based-on-motion-or-ringing-of-my-ring-doorbell/382208/15?u=mback2k

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @fronzbot, @mkmer, mind taking a look at this pull request as it has been labeled with an integration (blink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of blink can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign blink Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[frenck]

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

• A link to the release notes of this package version, and all versions in between.
• A link to the changelog of this package.
• A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Additionally, this seems to upgrade to a beta version of the library (considering the version number); we want to avoid using alpha/beta versions in general. What would be the reason to divert from that now?

Thanks already! 👍

../Frenck

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[mback2k]

• A link to the release notes of this package version, and all versions in between.

I updated the Proposed change section accordingly.

• A link to the changelog of this package.

Unfortunately, the changelog of the package itself wasn't updated with details:
https://github.com/fronzbot/blinkpy/blob/dev/CHANGES.rst

• A link to a Git(Hub) diff/compare view from the current version to the bumped version.

Also added in first comment, but for reference, here it is again:
fronzbot/blinkpy@v0.22.6...v0.23.0b8

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Sure, I think this will be relevant for a patch release of Home Assistant due to the authentication issue being solved.

Additionally, this seems to upgrade to a beta version of the library (considering the version number); we want to avoid using alpha/beta versions in general. What would be the reason to divert from that now?

I am not sure why @fronzbot decided to stay with a beta version for now, but for me the new version is working fine during local tests. Without this beta version, the Blink integration can no longer be freshly added/setup in Home Assistant. Existing authentication tokens can continue to be used and keep working, but as soon as you revoke the token via the Blink app and re-authentication/-setup is needed, the bugfixex from the new package version will be required.

I would propose to go with the beta version as a short term patch and then switch to (then hopefully available) stable version for the next Home Assistant release. Until the patch is released, for example, I am locked out of Blink from my production Home Assistant instance running on Home Assistant OS, because I removed the old token via the Blink app by mistake. (App GUI is flaky and sometimes performs action against wrong entry there, I actually wanted to remove one of the test tokens and not my prod token, but anyway...)

What do you think?

Thanks in advance and best regards,
Marc

[fronzbot]

I am not sure why @fronzbot decided to stay with a beta version for now, but for me the new version is working fine during local test

Because the beta version was released two days ago and I'm waiting for feedback from more than one user to ensure it fixes all issues. I typically wait about a week between beta and final releas. Please wait until a stable release is added before bumping this library version.

[mback2k]

Thanks for the clarification on your process here. Do you think it would make sense to at least bump to the beta version for the Home Assistant release candidate to get more feedback?

Another user reporting success with the new version:
https://community.home-assistant.io/t/start-recording-blink-camera-based-on-motion-or-ringing-of-my-ring-doorbell/382208/18?u=mback2k

[frenck]

Do you think it would make sense to at least bump to the beta version for the Home Assistant release candidate to get more feedback?

The next release candidate is still weeks out. So looking at the timeline above, that doesn't add up.

[mback2k]

Understood, thanks.

[mkmer]

LGTM, need to take this out of draft to get it in.

[mback2k]

Thanks! I was waiting on the CI to finish, but now it seems like the test failures are not related to this integration or library.

[mback2k]

Sorry for re-triggering the review after the CIs were done, but would you mind checking @mkmer ?

@frenck I think this is ready for merge and backport as bugfix.

[frenck]

Thanks, @mback2k 👍

../Frenck