Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better setup for android build version. #67

Merged
merged 2 commits into from
Sep 16, 2018
Merged

Better setup for android build version. #67

merged 2 commits into from
Sep 16, 2018

Conversation

hyochan
Copy link
Contributor

@hyochan hyochan commented Jul 15, 2018

React Native now has its project set up with default build version of androids sdk. Set android build version to that of rootProject’s to prevent from build failing cause of version mismatch.

React Native now has its project set up with default build version of androids sdk. Set android build version to that ofrootProjet``s to prevent from build failing cause of version mismatch.
@maicki
Copy link
Contributor

maicki commented Aug 24, 2018

@thorbenprimke Could you please take a look at this PR? Thanks!

Support older react-native version.
@hyochan
Copy link
Contributor Author

hyochan commented Aug 24, 2018

@maicki @thorbenprimke I just got notified and I updated code safer.

@maicki
Copy link
Contributor

maicki commented Sep 15, 2018

@dooboolab Hey - I would like to go forward with this, just some small improvements before landing. Can you extract setting the version via a function like:

def safeExtGet(prop, fallback) {
     rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
 }

and set each value like:

// ...
compileSdkVersion safeExtGet('compileSdkVersion', DEFAULT_COMPILE_SDK_VERSION)
// ...

Copy link
Contributor

@maicki maicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM let's get it in and approve on top

@maicki maicki merged commit 0b78730 into frostney:master Sep 16, 2018
@hyochan
Copy link
Contributor Author

hyochan commented Sep 16, 2018

@maicki Someone already gave PR on this one. Thanks for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants